Skip to content

perf(loader-runner): memoize resolver creation for improved performance#9403

Merged
h-a-n-a merged 1 commit intoweb-infra-dev:mainfrom
inottn:perf/loader
Feb 20, 2025
Merged

perf(loader-runner): memoize resolver creation for improved performance#9403
h-a-n-a merged 1 commit intoweb-infra-dev:mainfrom
inottn:perf/loader

Conversation

@inottn
Copy link
Collaborator

@inottn inottn commented Feb 20, 2025

Summary

close #9399

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 52f4069
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67b6c7777fb7d00008d8342a

@github-actions github-actions bot added the release: performance release: performance related release(mr only) label Feb 20, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 20, 2025

CodSpeed Performance Report

Merging #9403 will not alter performance

Comparing inottn:perf/loader (52f4069) with main (8b1ebe5)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 7 untouched benchmarks

Copy link
Contributor

@h-a-n-a h-a-n-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@h-a-n-a h-a-n-a merged commit ced4997 into web-infra-dev:main Feb 20, 2025
31 checks passed
@inottn inottn deleted the perf/loader branch February 20, 2025 07:17
@h-a-n-a h-a-n-a mentioned this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: performance release: performance related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: performance bottleneck in loader-runner resolver creation

2 participants