Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
1b7fdd6 to
04979a9
Compare
CodSpeed Performance ReportMerging #9401 will not alter performanceComparing 🎉 Hooray!
|
78ad19d to
4dd0cae
Compare
7b3cc40 to
b85db78
Compare
SyMind
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wait-on-check-actionto make sure the binary of build task is ready before running codspeed taskThis pull request includes several updates to the
jobssection in the.github/workflows/reusable-build.ymlfile. The key changes involve modifying the conditions and steps for the bench job, specifically around the installation of tools and the build process.Updates to the
jobssection:Modification of job dependencies and conditions:
runs-oncondition for thebenchjob to use theinputs.runnerinstead of the output from thebuildjob.Addition of new steps for the
benchjob:cargo-codspeedbinary, build the benchmark, and wait for the build job to complete.Removal of redundant steps:
cargo-codspeedbinary, and building the benchmark, as these have been restructured and added earlier in the workflow.Checklist