Skip to content

perf: revert opt-level to 3#9339

Merged
hardfist merged 1 commit intomainfrom
yj/opt-level-3
Feb 17, 2025
Merged

perf: revert opt-level to 3#9339
hardfist merged 1 commit intomainfrom
yj/opt-level-3

Conversation

@hardfist
Copy link
Copy Markdown
Contributor

@hardfist hardfist commented Feb 17, 2025

Summary

opt-level "s" cause 30% size reduction and 5% performance regression, we will find another way to reduce size while keep runtime performance

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 17, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit c027c9c
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67b2ec02ecbd8b000822046d

@github-actions github-actions bot added release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack. labels Feb 17, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Feb 17, 2025

CodSpeed Performance Report

Merging #9339 will improve performances by 16.47%

Comparing yj/opt-level-3 (c027c9c) with main (9a6a4f2)

Summary

⚡ 4 improvements
✅ 2 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
basic 3 ms 2.6 ms +16.47%
basic_sourcemap 3.2 ms 2.7 ms +16.14%
build_chunk_graph 101.7 ms 93.1 ms +9.27%
build_chunk_graph_parallel 80.6 ms 71.9 ms +12.09%

@hardfist hardfist enabled auto-merge (squash) February 17, 2025 09:44
@hardfist hardfist merged commit d1c321f into main Feb 17, 2025
74 checks passed
@hardfist hardfist deleted the yj/opt-level-3 branch February 17, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants