fix: persistent cache remove non-existent modules from make_failed_module#9309
Merged
jerrykingxyz merged 1 commit intomainfrom Feb 14, 2025
Merged
fix: persistent cache remove non-existent modules from make_failed_module#9309jerrykingxyz merged 1 commit intomainfrom
jerrykingxyz merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rspack canceled.
|
CodSpeed Performance ReportMerging #9309 will not alter performanceComparing 🎉 Hooray!
|
| Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|
| 🆕 | 10000_development |
N/A | 9 s | N/A |
| 🆕 | 10000_production |
N/A | 13.3 s | N/A |
LingyuCoder
approved these changes
Feb 14, 2025
This was
linked to
issues
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ModuleGraph generated from the persistent cache only contains modules that support serialization. Therefore, we need to filter make_failed_module to keep only the existing ones.
Checklist