refactor: module diagnostic action move to Diagnosable trait#9264
Merged
jerrykingxyz merged 2 commits intomainfrom Feb 12, 2025
Merged
refactor: module diagnostic action move to Diagnosable trait#9264jerrykingxyz merged 2 commits intomainfrom
Diagnosable trait#9264jerrykingxyz merged 2 commits intomainfrom
Conversation
Diagnosable traitDiagnosable trait
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
h-a-n-a
approved these changes
Feb 12, 2025
CodSpeed Performance ReportMerging #9264 will not alter performanceComparing 🎉 Hooray!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trait Diagnosable { - fn add_diagnostic(&self, _diagnostic: Diagnostic); + fn add_diagnostic(&mut self, _diagnostic: Diagnostic); - fn add_diagnostics(&self, _diagnostics: Vec<Diagnostic>); + fn add_diagnostics(&mut self, _diagnostics: Vec<Diagnostic>); - fn clone_diagnostics(&self) -> Vec<Diagnostic>; - fn take_diagnostics(&self) -> Vec<Diagnostic>; - fn pipe_diagnostics(&self, target: &dyn Diagnosable); }trait Module { - fn get_diagnostics(&self) -> Vec<Diagnostic>; } trait Diagnosable { + fn diagnostics(&self) -> Cow<[Diagnostic]>; }Checklist