Skip to content

fix(deps): govern graceful-fs sourcemap phantom dependencies#9259

Merged
SoonIter merged 4 commits intomainfrom
syt/fix/graceful-fs
Feb 12, 2025
Merged

fix(deps): govern graceful-fs sourcemap phantom dependencies#9259
SoonIter merged 4 commits intomainfrom
syt/fix/graceful-fs

Conversation

@SoonIter
Copy link
Copy Markdown
Member

@SoonIter SoonIter commented Feb 12, 2025 •
edited
Loading

Summary

  1. patch is not patched when upgrading graceful-fs

#7803

  1. graceful-fs and source-map are phantom dependencies

The CI isn't throwing errors because we're using pnpm run. The key difference between pnpm run and npm run is that pnpm run overrides the NODE_PATH environment variable to point to .pnpm/node_modules.

image

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 12, 2025 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 0e0fed7
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67ac4f7b5e329f00081ac484
😎 Deploy Preview https://deploy-preview-9259--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Feb 12, 2025
@hardfist
Copy link
Copy Markdown
Contributor

hardfist commented Feb 12, 2025

I'm not sure whether the patch is needed anymore, you can try remove it

@SoonIter SoonIter changed the title fix: govern graceful-fs dependency fix(deps): govern graceful-fs sourcemap phantom dependencies Feb 12, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Feb 12, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9259 will not alter performance

Comparing syt/fix/graceful-fs (0e0fed7) with main (b104095)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 6 untouched benchmarks

@SoonIter SoonIter requested a review from stormslowly February 12, 2025 04:47
@SoonIter
Copy link
Copy Markdown
Member Author

SoonIter commented Feb 12, 2025

I'm not sure whether the patch is needed anymore, you can try remove it

pnpm does not remove this patch, so do we

@stormslowly
Copy link
Copy Markdown
Contributor

stormslowly commented Feb 12, 2025

wait there are some more

hardfist
hardfist reviewed Feb 12, 2025
View reviewed changes
@SoonIter SoonIter merged commit 8b066ad into main Feb 12, 2025
33 checks passed
@SoonIter SoonIter deleted the syt/fix/graceful-fs branch February 12, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hardfist hardfist hardfist left review comments

@stormslowly stormslowly stormslowly approved these changes

Assignees

No one assigned

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SoonIter @hardfist @stormslowly