fix: introduce AsyncTask, make rebuildModule safer#9244
Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
d5d6b9d to
e107d3c
Compare
…order of invoking module_executor hook_after_make
e107d3c to
c757f72
Compare
CodSpeed Performance ReportMerging #9244 will not alter performanceComparing Summary
|
SyMind
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
close #9058
Introduce AsyncTask to replace MergeCaller, which is more robust. Make rebuildModule safe to use.
ModuleExecutor's
hook_after_makeshould be called afterfinish_modulesdoneChecklist