Skip to content

fix: WebWorkerTemplatePlugin should generate import-scripts chunk loading runtime#8523

Merged
h-a-n-a merged 2 commits intomainfrom
fix-worker-loader
Nov 25, 2024
Merged

fix: WebWorkerTemplatePlugin should generate import-scripts chunk loading runtime#8523
h-a-n-a merged 2 commits intomainfrom
fix-worker-loader

Conversation

@h-a-n-a
Copy link
Copy Markdown
Contributor

@h-a-n-a h-a-n-a commented Nov 25, 2024 •
edited
Loading

Summary

Fixed an issue where dynamic chunk manually created by worker-loader is failed to load.

See: https://github.com/webpack/webpack/blob/89dfc9a5c575dc691e3ac6a965d39c854fca3986/lib/webworker/WebWorkerTemplatePlugin.js#L20

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Nov 25, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 25, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 514a46f
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67443749f67d7c0008323a7a

@h-a-n-a h-a-n-a enabled auto-merge (squash) November 25, 2024 08:32
ahabhgk
ahabhgk previously approved these changes Nov 25, 2024
View reviewed changes
@h-a-n-a h-a-n-a merged commit 809be16 into main Nov 25, 2024
@h-a-n-a h-a-n-a deleted the fix-worker-loader branch November 25, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees

@h-a-n-a h-a-n-a

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@h-a-n-a @ahabhgk