Skip to content

fix(incremental): wrong runtime module when rebuild#8504

Merged
ahabhgk merged 2 commits intomainfrom
fix-inc-chunk-runtime-requirements
Nov 25, 2024
Merged

fix(incremental): wrong runtime module when rebuild#8504
ahabhgk merged 2 commits intomainfrom
fix-inc-chunk-runtime-requirements

Conversation

@ahabhgk
Copy link
Copy Markdown
Contributor

@ahabhgk ahabhgk commented Nov 21, 2024

Summary

Should have correct runtime modules in runtime chunk when rebuild

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@ahabhgk ahabhgk requested a review from JSerFeng November 21, 2024 10:10
@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Nov 21, 2024
@ahabhgk ahabhgk enabled auto-merge (squash) November 21, 2024 10:10
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 21, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit d1a2875
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/673f098170415000080c8a32

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Nov 21, 2024

CodSpeed Performance Report

Merging #8504 will not alter performance

Comparing fix-inc-chunk-runtime-requirements (d1a2875) with main (4f66057)

Summary

✅ 1 untouched benchmarks

@ahabhgk ahabhgk merged commit 4a2ac52 into main Nov 25, 2024
@ahabhgk ahabhgk deleted the fix-inc-chunk-runtime-requirements branch November 25, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants