fix: set the correct asset_info when extracting css#8454
Merged
JSerFeng merged 1 commit intoweb-infra-dev:mainfrom Nov 18, 2024
Merged
fix: set the correct asset_info when extracting css#8454JSerFeng merged 1 commit intoweb-infra-dev:mainfrom
JSerFeng merged 1 commit intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
JSerFeng
approved these changes
Nov 18, 2024
Contributor
|
Thanks ! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix #8431
The default asset_info is returned here:
rspack/crates/rspack_plugin_extract_css/src/plugin.rs
Line 415 in 9112e35
Therefore, the contenthash cannot be obtained here, leading to an unexpected termination of the subsequent process:
rspack/crates/rspack_plugin_real_content_hash/src/lib.rs
Lines 73 to 75 in 9112e35
Checklist