fix: align bytes ptr address for cacheable::from_byte#8450
Merged
jerrykingxyz merged 2 commits intomainfrom Nov 15, 2024
Merged
fix: align bytes ptr address for cacheable::from_byte#8450jerrykingxyz merged 2 commits intomainfrom
cacheable::from_byte#8450jerrykingxyz merged 2 commits intomainfrom
Conversation
✅ Deploy Preview for rspack canceled.
|
h-a-n-a
previously approved these changes
Nov 15, 2024
a5498e9 to
df9be77
Compare
df9be77 to
51e3f5b
Compare
cacheable::from_byte align bytes ptr address
cacheable::from_byte align bytes ptr addresscacheable::from_byte
h-a-n-a
approved these changes
Nov 15, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UnalignedPointererror in rkyv when miri test.cacheable_dynmiri test. The global register crate likeinventorynot work in miri test.Checklist