fix: css runtime should have hmr handler when lazy-compilation#8400
Merged
fix: css runtime should have hmr handler when lazy-compilation#8400
Conversation
✅ Deploy Preview for rspack canceled.
|
9674168 to
6122932
Compare
ahabhgk
previously approved these changes
Nov 11, 2024
6122932 to
d935118
Compare
ahabhgk
approved these changes
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The hook
runtimeRequirementInTreeis different compared to webpack, we have currentruntime_requirementsrepresents current runtime_requirements,all_runtime_requirementsrepresents all runtime_requirements, when insert a new RuntimeModule, the module should not depend on runtimeGlobals on runtime_requirements, it should use correct runtime_requirements at codegen phaseChecklist