Conversation
✅ Deploy Preview for rspack canceled.
|
Member
Author
|
!bench |
Member
Author
|
!eco-ci |
|
📝 Benchmark detail: Open
|
eb6991a to
820826c
Compare
JSerFeng
reviewed
Nov 11, 2024
Contributor
|
This pr depends on accessing a field within a raw pointer, for example But I wonder if access id here will panic ? And this is a solution that relies on UB ? Can we accept this @h-a-n-a |
8acb83d to
5b2e260
Compare
Contributor
No, this will not panic and it's more likely a undefined behavior if the memory you're accessing to is freed and it will likely to cause segmentation faults. All we need to do is to prevent user from accessing that value after the scope is dropped. |
67e7e90 to
d9844db
Compare
d9844db to
4162479
Compare
JSerFeng
approved these changes
Nov 13, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat: unify js dependency
Checklist