Skip to content

fix: variable name conflict with concatenate and runtime code#8386

Merged
chenjiahan merged 1 commit intoweb-infra-dev:mainfrom
inottn:fix/variable-name-conflict
Nov 25, 2024
Merged

fix: variable name conflict with concatenate and runtime code#8386
chenjiahan merged 1 commit intoweb-infra-dev:mainfrom
inottn:fix/variable-name-conflict

Conversation

@inottn
Copy link
Copy Markdown
Collaborator

@inottn inottn commented Nov 9, 2024

Summary

See webpack/webpack#18932 for background.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Nov 9, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 9, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 7126c66
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/672f85f8d33a7800084748c8

@inottn inottn force-pushed the fix/variable-name-conflict branch from 81e69ca to 7126c66 Compare November 9, 2024 15:55
@chenjiahan chenjiahan requested a review from JSerFeng November 25, 2024 10:01
Copy link
Copy Markdown
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chenjiahan chenjiahan merged commit b753080 into web-infra-dev:main Nov 25, 2024
@inottn inottn deleted the fix/variable-name-conflict branch November 25, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants