fix: compile time evaluation of __webpack_layer__#8381
Merged
ahabhgk merged 1 commit intoweb-infra-dev:mainfrom Nov 11, 2024
Merged
fix: compile time evaluation of __webpack_layer__#8381ahabhgk merged 1 commit intoweb-infra-dev:mainfrom
__webpack_layer__#8381ahabhgk merged 1 commit intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rspack ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
__webpack_layer__
ahabhgk
approved these changes
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
see #7848 and test cases for more details.
I found that there are also issues with the evaluation of typeof. It should check whether the layer exists. I fixed this in this PR as well.
Checklist