fix(cli): Run config function before looking for --config-name#8363
Merged
chenjiahan merged 1 commit intoweb-infra-dev:mainfrom Nov 7, 2024
Merged
fix(cli): Run config function before looking for --config-name#8363chenjiahan merged 1 commit intoweb-infra-dev:mainfrom
--config-name#8363chenjiahan merged 1 commit intoweb-infra-dev:mainfrom
Conversation
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
Member
|
@LingyuCoder can you check why the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the config is a function, we need to match
--config-nameon its return value, not the function itself.Checklist
tests/webpack-cli-test/build/config-name/config-name.test.jsseems to already have tests for this ("should work with config as a function","should work with multiple values for --config-name when the config is a function"), but it seems we never run those tests.