Skip to content

chore: bump to napi@3#8359

Merged
h-a-n-a merged 1 commit intomainfrom
update-napi
Nov 8, 2024
Merged

chore: bump to napi@3#8359
h-a-n-a merged 1 commit intomainfrom
update-napi

Conversation

@h-a-n-a
Copy link
Copy Markdown
Contributor

@h-a-n-a h-a-n-a commented Nov 6, 2024 •
edited
Loading

Summary

Upgraded NAPI to 3 (Alpha release).

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Nov 6, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 6, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 3f35d6c
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/672dbe7d783fa90008f444d0

@h-a-n-a h-a-n-a mentioned this pull request Nov 7, 2024
Closed
1 task
@h-a-n-a h-a-n-a force-pushed the update-napi branch 3 times, most recently from 8d5e949 to c414797 Compare November 8, 2024 07:22
@h-a-n-a h-a-n-a changed the title chore: napi@3 chore: bump to napi@3 Nov 8, 2024
@h-a-n-a
Copy link
Copy Markdown
Contributor Author

h-a-n-a commented Nov 8, 2024

!bench

@rspack-bot
Copy link
Copy Markdown

rspack-bot commented Nov 8, 2024 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2024-11-08 dfbe05f) Current Change
10000_big_production-mode + exec 44.5 s ± 1.64 s 44.2 s ± 466 ms -0.75 %
10000_development-mode + exec 1.84 s ± 19 ms 1.83 s ± 19 ms -0.37 %
10000_development-mode_hmr + exec 644 ms ± 4.5 ms 641 ms ± 9.4 ms -0.50 %
10000_production-mode + exec 2.43 s ± 34 ms 2.42 s ± 29 ms -0.28 %
arco-pro_development-mode + exec 1.79 s ± 60 ms 1.76 s ± 68 ms -1.71 %
arco-pro_development-mode_hmr + exec 430 ms ± 2.3 ms 431 ms ± 1.3 ms +0.16 %
arco-pro_production-mode + exec 3.2 s ± 61 ms 3.19 s ± 97 ms -0.21 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.25 s ± 63 ms 3.23 s ± 63 ms -0.70 %
threejs_development-mode_10x + exec 1.59 s ± 15 ms 1.57 s ± 14 ms -1.44 %
threejs_development-mode_10x_hmr + exec 777 ms ± 7.8 ms 773 ms ± 11 ms -0.58 %
threejs_production-mode_10x + exec 4.99 s ± 40 ms 4.97 s ± 42 ms -0.33 %

@h-a-n-a h-a-n-a marked this pull request as ready for review November 8, 2024 07:43
h-a-n-a
h-a-n-a commented Nov 8, 2024
View reviewed changes
@h-a-n-a h-a-n-a enabled auto-merge (squash) November 8, 2024 07:48
@h-a-n-a h-a-n-a merged commit b329f87 into main Nov 8, 2024
@h-a-n-a h-a-n-a deleted the update-napi branch November 8, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SyMind SyMind SyMind approved these changes

Assignees

@h-a-n-a h-a-n-a

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@h-a-n-a @rspack-bot @SyMind