Skip to content

fix(cli): missing exports.types field#8355

Merged
chenjiahan merged 1 commit intomainfrom
cli_types_1106
Nov 6, 2024
Merged

fix(cli): missing exports.types field#8355
chenjiahan merged 1 commit intomainfrom
cli_types_1106

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

@chenjiahan chenjiahan commented Nov 6, 2024 •
edited
Loading

Summary

@rspack/cli has been converted to a "dual package" and the exports.types is required to provide typing for the dist/index.mjs.

#8187

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Nov 6, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Nov 6, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 6, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 36bd5fc
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/672b23b4f2f9ab000893ee1e

@chenjiahan chenjiahan merged commit 8b4dcce into main Nov 6, 2024
@chenjiahan chenjiahan deleted the cli_types_1106 branch November 6, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Timeless0911 Timeless0911 Timeless0911 approved these changes

Assignees

@chenjiahan chenjiahan

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chenjiahan @Timeless0911