refactor: reuse AssetConditions for banner plugin#8350
Merged
9aoy merged 1 commit intoweb-infra-dev:mainfrom Nov 11, 2024
Merged
refactor: reuse AssetConditions for banner plugin#83509aoy merged 1 commit intoweb-infra-dev:mainfrom
9aoy merged 1 commit intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
chenjiahan
reviewed
Nov 6, 2024
Member
chenjiahan
left a comment
There was a problem hiding this comment.
Can you complete the PR summary to explain the changes 😄
Collaborator
Author
I was a bit busy today and forgot to add the summary. I'll add it later. 😄 |
9aoy
approved these changes
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current rule match is async, but it seems unnecessary. We can reuse existing AssetConditions to simplify the existing code.
Checklist