fix: correct usage of pnpm --filter in package scripts#8319
Merged
chenjiahan merged 1 commit intoweb-infra-dev:mainfrom Nov 3, 2024
Merged
fix: correct usage of pnpm --filter in package scripts#8319chenjiahan merged 1 commit intoweb-infra-dev:mainfrom
pnpm --filter in package scripts#8319chenjiahan merged 1 commit intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
chenjiahan
approved these changes
Nov 3, 2024
Member
chenjiahan
left a comment
There was a problem hiding this comment.
The single quotes work in macOS, thanks for making the scripts work in Windows. 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Using single quotes in
pnpm --filter '@rspack/*'results in"No projects matched the filters". Instead, we should use double quotes for proper functionality. (This issue may only occur onWindows, I don't have aMacto verify)Checklist