Skip to content

fix: runtime chunk hash should respect their reference order#8303

Merged
ahabhgk merged 8 commits intomainfrom
refactor-chunk-hash
Nov 4, 2024
Merged

fix: runtime chunk hash should respect their reference order#8303
ahabhgk merged 8 commits intomainfrom
refactor-chunk-hash

Conversation

@ahabhgk
Copy link
Copy Markdown
Contributor

@ahabhgk ahabhgk commented Oct 31, 2024

Summary

runtime chunk hash should depend on async entrypoint hash

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@ahabhgk
Copy link
Copy Markdown
Contributor Author

ahabhgk commented Oct 31, 2024

!bench

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Oct 31, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 31, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit ad34cc6
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/672865d0ed709400084b32b8
😎 Deploy Preview https://deploy-preview-8303--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rspack-bot
Copy link
Copy Markdown

rspack-bot commented Oct 31, 2024 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2024-10-31 02f0c85) Current Change
10000_big_production-mode + exec 49.3 s ± 1.56 s 49.2 s ± 1.05 s -0.37 %
10000_development-mode + exec 2.12 s ± 33 ms 2.11 s ± 26 ms -0.77 %
10000_development-mode_hmr + exec 638 ms ± 4.3 ms 640 ms ± 7.2 ms +0.36 %
10000_production-mode + exec 2.69 s ± 41 ms 2.69 s ± 50 ms -0.09 %
arco-pro_development-mode + exec 1.79 s ± 73 ms 1.8 s ± 74 ms +0.83 %
arco-pro_development-mode_hmr + exec 428 ms ± 1.1 ms 437 ms ± 1.9 ms +2.00 %
arco-pro_production-mode + exec 3.21 s ± 130 ms 3.18 s ± 69 ms -1.01 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.25 s ± 68 ms 3.23 s ± 53 ms -0.77 %
threejs_development-mode_10x + exec 1.62 s ± 20 ms 1.62 s ± 21 ms -0.22 %
threejs_development-mode_10x_hmr + exec 770 ms ± 13 ms 776 ms ± 10 ms +0.81 %
threejs_production-mode_10x + exec 5.01 s ± 27 ms 5.01 s ± 33 ms +0.08 %

@ahabhgk
Copy link
Copy Markdown
Contributor Author

ahabhgk commented Nov 1, 2024

!bench

@ahabhgk ahabhgk requested a review from LingyuCoder November 1, 2024 09:10
@rspack-bot
Copy link
Copy Markdown

rspack-bot commented Nov 1, 2024 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2024-11-01 4aeee85) Current Change
10000_big_production-mode + exec 47.5 s ± 1.45 s 49.7 s ± 592 ms +4.65 %
10000_development-mode + exec 2.08 s ± 13 ms 2.17 s ± 27 ms +4.54 %
10000_development-mode_hmr + exec 649 ms ± 13 ms 690 ms ± 4.5 ms +6.24 %
10000_production-mode + exec 2.62 s ± 29 ms 2.73 s ± 40 ms +4.40 %
arco-pro_development-mode + exec 1.78 s ± 79 ms 1.82 s ± 68 ms +2.28 %
arco-pro_development-mode_hmr + exec 428 ms ± 1.1 ms 438 ms ± 3.3 ms +2.19 %
arco-pro_production-mode + exec 3.22 s ± 82 ms 3.2 s ± 68 ms -0.46 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.22 s ± 79 ms 3.31 s ± 44 ms +2.87 %
threejs_development-mode_10x + exec 1.64 s ± 12 ms 1.64 s ± 19 ms -0.24 %
threejs_development-mode_10x_hmr + exec 784 ms ± 14 ms 783 ms ± 5.3 ms -0.11 %
threejs_production-mode_10x + exec 5.03 s ± 52 ms 5.06 s ± 42 ms +0.56 %

Threshold exceeded: ["10000_development-mode_hmr + exec"]

@ahabhgk ahabhgk changed the title fix: runtime chunk hash should depend on async entrypoint hash fix: runtime chunk hash should respect their reference order Nov 1, 2024
@ahabhgk
Copy link
Copy Markdown
Contributor Author

ahabhgk commented Nov 1, 2024

!bench

@rspack-bot
Copy link
Copy Markdown

rspack-bot commented Nov 1, 2024 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2024-11-01 4aeee85) Current Change
10000_big_production-mode + exec 47.5 s ± 1.45 s 49.8 s ± 1.69 s +4.71 %
10000_development-mode + exec 2.08 s ± 13 ms 2.18 s ± 21 ms +4.63 %
10000_development-mode_hmr + exec 649 ms ± 13 ms 688 ms ± 1.8 ms +5.87 %
10000_production-mode + exec 2.62 s ± 29 ms 2.74 s ± 34 ms +4.44 %
arco-pro_development-mode + exec 1.78 s ± 79 ms 1.82 s ± 77 ms +2.49 %
arco-pro_development-mode_hmr + exec 428 ms ± 1.1 ms 437 ms ± 1.5 ms +2.14 %
arco-pro_production-mode + exec 3.22 s ± 82 ms 3.21 s ± 70 ms -0.03 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.22 s ± 79 ms 3.29 s ± 73 ms +2.20 %
threejs_development-mode_10x + exec 1.64 s ± 12 ms 1.64 s ± 20 ms -0.23 %
threejs_development-mode_10x_hmr + exec 784 ms ± 14 ms 783 ms ± 2.6 ms -0.14 %
threejs_production-mode_10x + exec 5.03 s ± 52 ms 5.05 s ± 18 ms +0.39 %

Threshold exceeded: ["10000_development-mode_hmr + exec"]

LingyuCoder
LingyuCoder previously approved these changes Nov 1, 2024
View reviewed changes
@ahabhgk
Copy link
Copy Markdown
Contributor Author

ahabhgk commented Nov 1, 2024

!bench

@rspack-bot
Copy link
Copy Markdown

rspack-bot commented Nov 1, 2024

⏳ Triggered benchmark: Open

@ahabhgk
Copy link
Copy Markdown
Contributor Author

ahabhgk commented Nov 1, 2024

!bench

@rspack-bot
Copy link
Copy Markdown

rspack-bot commented Nov 1, 2024 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2024-11-01 4aeee85) Current Change
10000_big_production-mode + exec 47.5 s ± 1.45 s 49.3 s ± 411 ms +3.72 %
10000_development-mode + exec 2.08 s ± 13 ms 2.16 s ± 15 ms +4.03 %
10000_development-mode_hmr + exec 649 ms ± 13 ms 686 ms ± 9.4 ms +5.68 %
10000_production-mode + exec 2.62 s ± 29 ms 2.71 s ± 31 ms +3.53 %
arco-pro_development-mode + exec 1.78 s ± 79 ms 1.83 s ± 87 ms +3.04 %
arco-pro_development-mode_hmr + exec 428 ms ± 1.1 ms 437 ms ± 1.6 ms +2.02 %
arco-pro_production-mode + exec 3.22 s ± 82 ms 3.24 s ± 92 ms +0.63 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.22 s ± 79 ms 3.25 s ± 106 ms +0.84 %
threejs_development-mode_10x + exec 1.64 s ± 12 ms 1.64 s ± 13 ms -0.13 %
threejs_development-mode_10x_hmr + exec 784 ms ± 14 ms 783 ms ± 6.9 ms -0.08 %
threejs_production-mode_10x + exec 5.03 s ± 52 ms 5.05 s ± 34 ms +0.37 %

Threshold exceeded: ["10000_development-mode_hmr + exec"]

@ahabhgk
Copy link
Copy Markdown
Contributor Author

ahabhgk commented Nov 1, 2024

!bench

@rspack-bot
Copy link
Copy Markdown

rspack-bot commented Nov 1, 2024

⏳ Triggered benchmark: Open

@ahabhgk
Copy link
Copy Markdown
Contributor Author

ahabhgk commented Nov 4, 2024

!bench

@rspack-bot
Copy link
Copy Markdown

rspack-bot commented Nov 4, 2024 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2024-11-04 a987332) Current Change
10000_big_production-mode + exec 45.9 s ± 613 ms 49.6 s ± 739 ms +7.93 %
10000_development-mode + exec 1.84 s ± 17 ms 2.14 s ± 35 ms +16.40 %
10000_development-mode_hmr + exec 645 ms ± 12 ms 645 ms ± 11 ms 0.00 %
10000_production-mode + exec 2.4 s ± 19 ms 2.74 s ± 41 ms +14.11 %
arco-pro_development-mode + exec 1.79 s ± 63 ms 1.83 s ± 86 ms +2.59 %
arco-pro_development-mode_hmr + exec 429 ms ± 1.2 ms 429 ms ± 1.5 ms +0.18 %
arco-pro_production-mode + exec 3.19 s ± 87 ms 3.21 s ± 58 ms +0.68 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.27 s ± 50 ms 3.27 s ± 94 ms +0.11 %
threejs_development-mode_10x + exec 1.58 s ± 7.7 ms 1.63 s ± 12 ms +3.20 %
threejs_development-mode_10x_hmr + exec 784 ms ± 4.2 ms 771 ms ± 8.9 ms -1.60 %
threejs_production-mode_10x + exec 4.93 s ± 40 ms 5.03 s ± 34 ms +1.93 %

Threshold exceeded: ["10000_big_production-mode + exec","10000_development-mode + exec","10000_production-mode + exec"]

@ahabhgk ahabhgk force-pushed the refactor-chunk-hash branch from a999f13 to ad34cc6 Compare November 4, 2024 06:12
@ahabhgk
Copy link
Copy Markdown
Contributor Author

ahabhgk commented Nov 4, 2024

!bench

@rspack-bot
Copy link
Copy Markdown

rspack-bot commented Nov 4, 2024 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2024-11-04 a987332) Current Change
10000_big_production-mode + exec 45.9 s ± 613 ms 44.2 s ± 1.14 s -3.64 %
10000_development-mode + exec 1.84 s ± 17 ms 1.83 s ± 26 ms -0.71 %
10000_development-mode_hmr + exec 645 ms ± 12 ms 645 ms ± 4 ms +0.01 %
10000_production-mode + exec 2.4 s ± 19 ms 2.41 s ± 38 ms +0.60 %
arco-pro_development-mode + exec 1.79 s ± 63 ms 1.76 s ± 78 ms -1.72 %
arco-pro_development-mode_hmr + exec 429 ms ± 1.2 ms 430 ms ± 0.9 ms +0.41 %
arco-pro_production-mode + exec 3.19 s ± 87 ms 3.21 s ± 56 ms +0.58 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.27 s ± 50 ms 3.22 s ± 70 ms -1.30 %
threejs_development-mode_10x + exec 1.58 s ± 7.7 ms 1.57 s ± 18 ms -0.33 %
threejs_development-mode_10x_hmr + exec 784 ms ± 4.2 ms 774 ms ± 9.3 ms -1.26 %
threejs_production-mode_10x + exec 4.93 s ± 40 ms 4.94 s ± 32 ms +0.22 %

@ahabhgk ahabhgk requested a review from LingyuCoder November 4, 2024 06:20
@ahabhgk ahabhgk enabled auto-merge (squash) November 4, 2024 06:20
@ahabhgk ahabhgk merged commit 5c6f47a into main Nov 4, 2024
@ahabhgk ahabhgk deleted the refactor-chunk-hash branch November 4, 2024 06:59
@chenjiahan chenjiahan mentioned this pull request Jan 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

Assignees

@ahabhgk ahabhgk

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahabhgk @rspack-bot @LingyuCoder