perf(core): replace neo-async with a minimal helper#8282
Merged
chenjiahan merged 2 commits intomainfrom Oct 31, 2024
Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
Member
Author
|
!eco-ci |
LingyuCoder
approved these changes
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
neo-async contains a lot of async utilities (4k LOC) and it has not been updated for more than four years.
Rspack only uses the
each()util ofneo-async, so we can replaceneo-asyncwith a minimaleachhelper to reduce bundle size and improve startup performance.Comparison
Compare the
@rspack/core/dist/index.jsbundle:Checklist