Skip to content

fix(type): Make iterators compatible with TS 5.6 --target ESNext#8279

Merged
SoonIter merged 1 commit intoweb-infra-dev:mainfrom
andersk:iterator-types
Oct 31, 2024
Merged

fix(type): Make iterators compatible with TS 5.6 --target ESNext#8279
SoonIter merged 1 commit intoweb-infra-dev:mainfrom
andersk:iterator-types

Conversation

@andersk
Copy link
Copy Markdown
Contributor

@andersk andersk commented Oct 31, 2024

Summary

Use ReturnType<> to avoid explicitly naming the types of builtin iterators that have changed in 5.6, and convert manually implemented iterators to generators so they are compatible with builtin iterators under --target ESNext.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 31, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Oct 31, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 31, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 433a989
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6722ed7701b76800080755a0

@chenjiahan chenjiahan requested a review from SoonIter October 31, 2024 02:15
andersk
andersk commented Oct 31, 2024
View reviewed changes
@andersk
fix(type): Make iterators compatible with TS 5.6 --target ESNext
433a989 
Use ReturnType<> to avoid explicitly naming the types of builtin
iterators that have changed in 5.6, and convert manually implemented
iterators to generators so they are compatible with builtin iterators
under --target ESNext.

Fixes part of web-infra-dev#8277.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
SoonIter
SoonIter approved these changes Oct 31, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@SoonIter SoonIter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks❤️️

@SoonIter SoonIter enabled auto-merge (squash) October 31, 2024 03:34
@SoonIter SoonIter mentioned this pull request Oct 31, 2024
Closed
@SoonIter SoonIter merged commit dfde1fd into web-infra-dev:main Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SoonIter SoonIter SoonIter approved these changes

Assignees

No one assigned

Labels

release: bug fix release: bug related release(mr only)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andersk @CLAassistant @SoonIter