Skip to content

refactor(rspack_napi): simplify the logic of JsRegExp#8254

Merged
h-a-n-a merged 2 commits intoweb-infra-dev:mainfrom
shulaoda:refactor/js-reg-exp
Oct 31, 2024
Merged

refactor(rspack_napi): simplify the logic of JsRegExp#8254
h-a-n-a merged 2 commits intoweb-infra-dev:mainfrom
shulaoda:refactor/js-reg-exp

Conversation

@shulaoda
Copy link
Copy Markdown
Contributor

@shulaoda shulaoda commented Oct 29, 2024 •
edited
Loading

Summary

Next, I plan to unify RawRegex and JsRegExp.

rspack/crates/rspack_binding_values/src/regex.rs

Lines 5 to 9 in 85bb238

#[napi(object)]
pub struct RawRegex {
pub source: String,
pub flags: String,
}

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Oct 29, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e48ffa8
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6721de7e6a4dce0008269c35
😎 Deploy Preview https://deploy-preview-8254--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shulaoda shulaoda requested a review from h-a-n-a October 29, 2024 15:04
@shulaoda shulaoda marked this pull request as draft October 29, 2024 15:34
@h-a-n-a
Copy link
Copy Markdown
Contributor

h-a-n-a commented Oct 30, 2024

Is there any work left to do?

@shulaoda shulaoda marked this pull request as ready for review October 30, 2024 07:08
@shulaoda
Copy link
Copy Markdown
Contributor Author

shulaoda commented Oct 30, 2024 •
edited
Loading

Is there any work left to do?

I found that instanceof is less reliable compared to Object.prototype.toString.call, as it doesn’t work consistently across environments like web workers and iframes. All current work has been completed now.

@shulaoda shulaoda force-pushed the refactor/js-reg-exp branch from 2254f55 to e48ffa8 Compare October 30, 2024 07:21
@SoonIter
Copy link
Copy Markdown
Member

SoonIter commented Oct 30, 2024

https://www.githubstatus.com/incidents/9yk1fbk0qjjc
image

github runner is blocking

@shulaoda shulaoda mentioned this pull request Oct 30, 2024
Closed
@h-a-n-a
Copy link
Copy Markdown
Contributor

h-a-n-a commented Oct 31, 2024

Thanks

@h-a-n-a h-a-n-a merged commit 37a681d into web-infra-dev:main Oct 31, 2024
@shulaoda shulaoda deleted the refactor/js-reg-exp branch October 31, 2024 07:44
@shulaoda shulaoda mentioned this pull request Oct 31, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@h-a-n-a h-a-n-a h-a-n-a approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shulaoda @h-a-n-a @SoonIter