Skip to content

docs: should enable swc keepImportAttributes configuration when use Rule.with#8239

Merged
chenjiahan merged 1 commit intomainfrom
docs/keepImportAttributes
Oct 28, 2024
Merged

docs: should enable swc keepImportAttributes configuration when use Rule.with#8239
chenjiahan merged 1 commit intomainfrom
docs/keepImportAttributes

Conversation

@9aoy
Copy link
Copy Markdown
Contributor

@9aoy 9aoy commented Oct 28, 2024

Summary

keepImportAttributes is undocumented in swc doc, only keepImportAssertions.

https://github.com/tc39/proposal-import-attributes

image

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: document release: document related release(mr only) team The issue/pr is created by the member of Rspack. labels Oct 28, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 28, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit ea15f44
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/671f5a5dc1596a0008c907ef
😎 Deploy Preview https://deploy-preview-8239--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@9aoy 9aoy requested a review from chenjiahan October 28, 2024 09:42
@chenjiahan chenjiahan merged commit 66aa425 into main Oct 28, 2024
@chenjiahan chenjiahan deleted the docs/keepImportAttributes branch October 28, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: document release: document related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants