refactor: use async thread pool by hardfist · Pull Request #8226 · web-infra-dev/rspack

hardfist · 2024-10-26T14:12:42Z

Summary

Current Implementation Issues:

CPU-bound tasks are spawned using spawn_blocking, which:
• Moves blocked tasks to other runtime threads, negatively impacting CPU affinity.
• Incurs additional costs due to task migration.
• Creates new threads for each spawn_blocking call until reaching the thread limit, potentially causing wait times and bring thread scheduler costs.
The main thread uses block_on for changing global state, which:
• Runs in a synchronous context, blocking the entire thread.

Proposed Solution:

This PR implements the following changes:

Utilizes Tokio’s multi-thread runtime as an asynchronous thread pool.
Executes all CPU-bound tasks in the main runtime thread instead of blocking threads.

Key Improvements:

• CPU-bound tasks run in the main runtime thread, effectively using it as an asynchronous thread pool.
• The main thread operates in an asynchronous context, eliminating the need for block_on calls.

Future Steps:

We still have numerous blocking calls that significantly impact performance. The next phase involves migrating all blocking calls to async/await calls.

[Tracking]: migrate all blocking call to async call #8312

Checklist

Tests updated (or not required).
Documentation updated (or not required).

hardfist · 2024-10-26T14:12:50Z

!bench

netlify · 2024-10-26T14:13:00Z

✅ Deploy Preview for rspack canceled.

Name	Link
🔨 Latest commit	`cd03d15`
🔍 Latest deploy log	https://app.netlify.com/sites/rspack/deploys/6724afc006327f0008218dca

rspack-bot · 2024-10-26T14:13:11Z

⏳ Triggered benchmark: Open

hardfist · 2024-10-26T14:45:12Z

!bench

rspack-bot · 2024-10-26T14:45:33Z

⏳ Triggered benchmark: Open

hardfist · 2024-10-26T14:52:06Z

!bench

rspack-bot · 2024-10-26T14:52:25Z

📝 Benchmark detail: Open

Name	Base (2024-10-26 e9e81bc)	Current	Change
10000_development-mode + exec	2.12 s ± 33 ms	2.23 s ± 17 ms	+5.00 %
10000_development-mode_hmr + exec	671 ms ± 17 ms	651 ms ± 17 ms	-2.98 %
10000_production-mode + exec	2.69 s ± 43 ms	2.78 s ± 27 ms	+3.10 %
arco-pro_development-mode + exec	1.81 s ± 47 ms	1.78 s ± 59 ms	-1.69 %
arco-pro_development-mode_hmr + exec	428 ms ± 2 ms	429 ms ± 2.8 ms	+0.23 %
arco-pro_production-mode + exec	3.22 s ± 78 ms	3.19 s ± 99 ms	-0.91 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec	3.26 s ± 93 ms	3.26 s ± 60 ms	-0.08 %
threejs_development-mode_10x + exec	1.62 s ± 23 ms	1.62 s ± 15 ms	+0.19 %
threejs_development-mode_10x_hmr + exec	766 ms ± 13 ms	766 ms ± 16 ms	+0.05 %
threejs_production-mode_10x + exec	5 s ± 35 ms	5.03 s ± 30 ms	+0.57 %

Threshold exceeded: ["10000_development-mode + exec"]

hardfist · 2024-10-26T15:10:07Z

!bench

rspack-bot · 2024-10-26T15:10:29Z

📝 Benchmark detail: Open

Name	Base (2024-10-26 e9e81bc)	Current	Change
10000_development-mode + exec	2.12 s ± 33 ms	2.2 s ± 25 ms	+3.72 %
10000_development-mode_hmr + exec	671 ms ± 17 ms	651 ms ± 6.9 ms	-3.01 %
10000_production-mode + exec	2.69 s ± 43 ms	2.76 s ± 37 ms	+2.50 %
arco-pro_development-mode + exec	1.81 s ± 47 ms	1.76 s ± 56 ms	-2.75 %
arco-pro_development-mode_hmr + exec	428 ms ± 2 ms	429 ms ± 2.1 ms	+0.18 %
arco-pro_production-mode + exec	3.22 s ± 78 ms	3.19 s ± 74 ms	-0.81 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec	3.26 s ± 93 ms	3.24 s ± 101 ms	-0.66 %
threejs_development-mode_10x + exec	1.62 s ± 23 ms	1.63 s ± 26 ms	+0.90 %
threejs_development-mode_10x_hmr + exec	766 ms ± 13 ms	780 ms ± 11 ms	+1.82 %
threejs_production-mode_10x + exec	5 s ± 35 ms	5.06 s ± 48 ms	+1.14 %

hardfist · 2024-10-26T15:40:18Z

!bench

rspack-bot · 2024-10-26T15:40:44Z

📝 Benchmark detail: Open

Name	Base (2024-10-26 e9e81bc)	Current	Change
10000_development-mode + exec	2.12 s ± 33 ms	2.21 s ± 35 ms	+4.21 %
10000_development-mode_hmr + exec	671 ms ± 17 ms	649 ms ± 8.7 ms	-3.31 %
10000_production-mode + exec	2.69 s ± 43 ms	2.76 s ± 29 ms	+2.58 %
arco-pro_development-mode + exec	1.81 s ± 47 ms	1.74 s ± 66 ms	-3.89 %
arco-pro_development-mode_hmr + exec	428 ms ± 2 ms	429 ms ± 2.4 ms	+0.23 %
arco-pro_production-mode + exec	3.22 s ± 78 ms	3.19 s ± 86 ms	-0.76 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec	3.26 s ± 93 ms	3.22 s ± 97 ms	-1.25 %
threejs_development-mode_10x + exec	1.62 s ± 23 ms	1.63 s ± 15 ms	+0.85 %
threejs_development-mode_10x_hmr + exec	766 ms ± 13 ms	777 ms ± 6.4 ms	+1.44 %
threejs_production-mode_10x + exec	5 s ± 35 ms	5.05 s ± 34 ms	+0.97 %

hardfist · 2024-10-26T16:12:58Z

!bench

rspack-bot · 2024-10-26T16:13:22Z

📝 Benchmark detail: Open

Name	Base (2024-10-26 e9e81bc)	Current	Change
10000_development-mode + exec	2.12 s ± 33 ms	2.2 s ± 32 ms	+3.90 %
10000_development-mode_hmr + exec	671 ms ± 17 ms	646 ms ± 18 ms	-3.83 %
10000_production-mode + exec	2.69 s ± 43 ms	2.77 s ± 39 ms	+2.73 %
arco-pro_development-mode + exec	1.81 s ± 47 ms	1.77 s ± 80 ms	-2.49 %
arco-pro_development-mode_hmr + exec	428 ms ± 2 ms	428 ms ± 2.6 ms	+0.15 %
arco-pro_production-mode + exec	3.22 s ± 78 ms	3.18 s ± 63 ms	-1.18 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec	3.26 s ± 93 ms	3.21 s ± 88 ms	-1.64 %
threejs_development-mode_10x + exec	1.62 s ± 23 ms	1.63 s ± 16 ms	+0.82 %
threejs_development-mode_10x_hmr + exec	766 ms ± 13 ms	784 ms ± 17 ms	+2.33 %
threejs_production-mode_10x + exec	5 s ± 35 ms	5.05 s ± 22 ms	+1.03 %

hardfist · 2024-10-27T00:20:37Z

!bench

rspack-bot · 2024-10-27T00:20:58Z

📝 Benchmark detail: Open

Name	Base (2024-10-27 0db8b94)	Current	Change
10000_development-mode + exec	2.12 s ± 41 ms	2.2 s ± 26 ms	+3.83 %
10000_development-mode_hmr + exec	675 ms ± 22 ms	650 ms ± 4.3 ms	-3.77 %
10000_production-mode + exec	2.71 s ± 64 ms	2.76 s ± 31 ms	+1.78 %
arco-pro_development-mode + exec	1.8 s ± 64 ms	1.75 s ± 65 ms	-2.50 %
arco-pro_development-mode_hmr + exec	429 ms ± 4.3 ms	429 ms ± 0.67 ms	-0.05 %
arco-pro_production-mode + exec	3.17 s ± 50 ms	3.19 s ± 86 ms	+0.40 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec	3.24 s ± 78 ms	3.2 s ± 66 ms	-1.35 %
threejs_development-mode_10x + exec	1.62 s ± 19 ms	1.64 s ± 16 ms	+1.24 %
threejs_development-mode_10x_hmr + exec	772 ms ± 19 ms	781 ms ± 8.6 ms	+1.13 %
threejs_production-mode_10x + exec	5.01 s ± 32 ms	5.05 s ± 33 ms	+0.66 %

hardfist · 2024-10-27T01:15:58Z

!bench

rspack-bot · 2024-10-27T01:16:20Z

📝 Benchmark detail: Open

Name	Base (2024-10-27 0db8b94)	Current	Change
10000_development-mode + exec	2.12 s ± 41 ms	2.23 s ± 22 ms	+5.15 %
10000_development-mode_hmr + exec	675 ms ± 22 ms	656 ms ± 14 ms	-2.84 %
10000_production-mode + exec	2.71 s ± 64 ms	2.74 s ± 33 ms	+1.09 %
arco-pro_development-mode + exec	1.8 s ± 64 ms	1.76 s ± 88 ms	-2.12 %
arco-pro_development-mode_hmr + exec	429 ms ± 4.3 ms	430 ms ± 1.2 ms	+0.11 %
arco-pro_production-mode + exec	3.17 s ± 50 ms	3.19 s ± 70 ms	+0.45 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec	3.24 s ± 78 ms	3.23 s ± 79 ms	-0.22 %
threejs_development-mode_10x + exec	1.62 s ± 19 ms	1.63 s ± 12 ms	+0.41 %
threejs_development-mode_10x_hmr + exec	772 ms ± 19 ms	777 ms ± 16 ms	+0.59 %
threejs_production-mode_10x + exec	5.01 s ± 32 ms	5.05 s ± 26 ms	+0.62 %

Threshold exceeded: ["10000_development-mode + exec"]

hardfist · 2024-10-27T12:27:52Z

!bench

rspack-bot · 2024-10-27T12:28:16Z

📝 Benchmark detail: Open

Name	Base (2024-10-27 0db8b94)	Current	Change
10000_development-mode + exec	2.12 s ± 41 ms	2.19 s ± 27 ms	+3.16 %
10000_development-mode_hmr + exec	675 ms ± 22 ms	659 ms ± 6.3 ms	-2.35 %
10000_production-mode + exec	2.71 s ± 64 ms	2.74 s ± 46 ms	+1.14 %
arco-pro_development-mode + exec	1.8 s ± 64 ms	1.77 s ± 82 ms	-1.64 %
arco-pro_development-mode_hmr + exec	429 ms ± 4.3 ms	429 ms ± 1.3 ms	+0.07 %
arco-pro_production-mode + exec	3.17 s ± 50 ms	3.27 s ± 72 ms	+3.06 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec	3.24 s ± 78 ms	3.35 s ± 87 ms	+3.35 %
threejs_development-mode_10x + exec	1.62 s ± 19 ms	1.62 s ± 22 ms	+0.21 %
threejs_development-mode_10x_hmr + exec	772 ms ± 19 ms	776 ms ± 9.8 ms	+0.47 %
threejs_production-mode_10x + exec	5.01 s ± 32 ms	5.36 s ± 50 ms	+6.92 %

Threshold exceeded: ["threejs_production-mode_10x + exec"]

hardfist · 2024-10-28T12:55:18Z

!bench

rspack-bot · 2024-10-28T12:55:41Z

📝 Benchmark detail: Open

Name	Base (2024-10-28 0db8b94)	Current	Change
10000_development-mode + exec	2.13 s ± 34 ms	2.22 s ± 32 ms	+4.22 %
10000_development-mode_hmr + exec	674 ms ± 22 ms	667 ms ± 5 ms	-0.95 %
10000_production-mode + exec	2.7 s ± 47 ms	2.73 s ± 50 ms	+1.38 %
arco-pro_development-mode + exec	1.78 s ± 72 ms	1.8 s ± 65 ms	+1.30 %
arco-pro_development-mode_hmr + exec	428 ms ± 2.2 ms	430 ms ± 2.1 ms	+0.47 %
arco-pro_production-mode + exec	3.21 s ± 53 ms	3.27 s ± 80 ms	+1.70 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec	3.22 s ± 58 ms	3.36 s ± 73 ms	+4.47 %
threejs_development-mode_10x + exec	1.62 s ± 22 ms	1.63 s ± 25 ms	+0.73 %
threejs_development-mode_10x_hmr + exec	759 ms ± 9.9 ms	772 ms ± 7.8 ms	+1.69 %
threejs_production-mode_10x + exec	5.01 s ± 29 ms	5.36 s ± 45 ms	+6.98 %

Threshold exceeded: ["threejs_production-mode_10x + exec"]

hardfist · 2024-10-29T02:24:15Z

!bench

rspack-bot · 2024-10-29T02:24:40Z

📝 Benchmark detail: Open

Name	Base (2024-10-29 a901d54)	Current	Change
10000_development-mode + exec	2.11 s ± 23 ms	2.2 s ± 26 ms	+3.88 %
10000_development-mode_hmr + exec	672 ms ± 22 ms	659 ms ± 4.9 ms	-1.90 %
10000_production-mode + exec	2.71 s ± 62 ms	2.77 s ± 23 ms	+2.22 %
arco-pro_development-mode + exec	1.78 s ± 66 ms	1.76 s ± 74 ms	-1.11 %
arco-pro_development-mode_hmr + exec	430 ms ± 8.4 ms	429 ms ± 2.7 ms	-0.19 %
arco-pro_production-mode + exec	3.2 s ± 91 ms	3.26 s ± 65 ms	+2.08 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec	3.23 s ± 81 ms	3.33 s ± 84 ms	+2.91 %
threejs_development-mode_10x + exec	1.61 s ± 18 ms	1.66 s ± 19 ms	+2.78 %
threejs_development-mode_10x_hmr + exec	765 ms ± 11 ms	803 ms ± 7.7 ms	+4.96 %
threejs_production-mode_10x + exec	5.02 s ± 35 ms	5.4 s ± 28 ms	+7.61 %

Threshold exceeded: ["threejs_production-mode_10x + exec"]

hardfist · 2024-10-29T02:53:23Z

!bench

rspack-bot · 2024-10-29T02:53:44Z

📝 Benchmark detail: Open

Name	Base (2024-10-29 a901d54)	Current	Change
10000_development-mode + exec	2.11 s ± 23 ms	2.24 s ± 16 ms	+5.76 %
10000_development-mode_hmr + exec	672 ms ± 22 ms	648 ms ± 7 ms	-3.61 %
10000_production-mode + exec	2.71 s ± 62 ms	2.79 s ± 53 ms	+2.65 %
arco-pro_development-mode + exec	1.78 s ± 66 ms	1.75 s ± 64 ms	-1.59 %
arco-pro_development-mode_hmr + exec	430 ms ± 8.4 ms	430 ms ± 1.4 ms	-0.11 %
arco-pro_production-mode + exec	3.2 s ± 91 ms	3.28 s ± 83 ms	+2.62 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec	3.23 s ± 81 ms	3.35 s ± 108 ms	+3.47 %
threejs_development-mode_10x + exec	1.61 s ± 18 ms	1.65 s ± 23 ms	+2.36 %
threejs_development-mode_10x_hmr + exec	765 ms ± 11 ms	806 ms ± 16 ms	+5.29 %
threejs_production-mode_10x + exec	5.02 s ± 35 ms	5.41 s ± 37 ms	+7.82 %

Threshold exceeded: ["10000_development-mode + exec","threejs_development-mode_10x_hmr + exec","threejs_production-mode_10x + exec"]

hardfist · 2024-10-29T06:58:02Z

!bench

rspack-bot · 2024-11-01T06:24:09Z

📝 Benchmark detail: Open

Name	Base (2024-11-01 4aeee85)	Current	Change
10000_big_production-mode + exec	47.5 s ± 1.45 s	42.8 s ± 3.01 s	-9.84 %
10000_development-mode + exec	2.08 s ± 13 ms	1.84 s ± 25 ms	-11.34 %
10000_development-mode_hmr + exec	649 ms ± 13 ms	648 ms ± 16 ms	-0.29 %
10000_production-mode + exec	2.62 s ± 29 ms	2.45 s ± 32 ms	-6.48 %
arco-pro_development-mode + exec	1.78 s ± 79 ms	1.79 s ± 73 ms	+0.55 %
arco-pro_development-mode_hmr + exec	428 ms ± 1.1 ms	429 ms ± 2 ms	+0.17 %
arco-pro_production-mode + exec	3.22 s ± 82 ms	3.32 s ± 55 ms	+3.22 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec	3.22 s ± 79 ms	3.33 s ± 83 ms	+3.34 %
threejs_development-mode_10x + exec	1.64 s ± 12 ms	1.66 s ± 15 ms	+0.80 %
threejs_development-mode_10x_hmr + exec	784 ms ± 14 ms	777 ms ± 15 ms	-0.87 %
threejs_production-mode_10x + exec	5.03 s ± 52 ms	5.39 s ± 33 ms	+7.22 %

Threshold exceeded: ["threejs_production-mode_10x + exec"]

hardfist · 2024-11-01T06:52:38Z

!bench

rspack-bot · 2024-11-01T06:53:00Z

📝 Benchmark detail: Open

Name	Base (2024-11-01 4aeee85)	Current	Change
10000_big_production-mode + exec	47.5 s ± 1.45 s	41.3 s ± 1.5 s	-13.10 %
10000_development-mode + exec	2.08 s ± 13 ms	1.86 s ± 33 ms	-10.59 %
10000_development-mode_hmr + exec	649 ms ± 13 ms	656 ms ± 6.9 ms	+0.97 %
10000_production-mode + exec	2.62 s ± 29 ms	2.43 s ± 43 ms	-7.36 %
arco-pro_development-mode + exec	1.78 s ± 79 ms	1.76 s ± 80 ms	-0.97 %
arco-pro_development-mode_hmr + exec	428 ms ± 1.1 ms	429 ms ± 2.3 ms	+0.10 %
arco-pro_production-mode + exec	3.22 s ± 82 ms	3.32 s ± 99 ms	+3.35 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec	3.22 s ± 79 ms	3.31 s ± 87 ms	+2.83 %
threejs_development-mode_10x + exec	1.64 s ± 12 ms	1.66 s ± 15 ms	+1.05 %
threejs_development-mode_10x_hmr + exec	784 ms ± 14 ms	775 ms ± 12 ms	-1.10 %
threejs_production-mode_10x + exec	5.03 s ± 52 ms	5.4 s ± 29 ms	+7.43 %

Threshold exceeded: ["threejs_production-mode_10x + exec"]

hardfist · 2024-11-01T07:55:34Z

!bench

rspack-bot · 2024-11-01T07:55:56Z

📝 Benchmark detail: Open

Name	Base (2024-11-01 4aeee85)	Current	Change
10000_big_production-mode + exec	47.5 s ± 1.45 s	43.9 s ± 606 ms	-7.56 %
10000_development-mode + exec	2.08 s ± 13 ms	1.86 s ± 28 ms	-10.71 %
10000_development-mode_hmr + exec	649 ms ± 13 ms	649 ms ± 15 ms	-0.07 %
10000_production-mode + exec	2.62 s ± 29 ms	2.44 s ± 27 ms	-7.02 %
arco-pro_development-mode + exec	1.78 s ± 79 ms	1.77 s ± 69 ms	-0.76 %
arco-pro_development-mode_hmr + exec	428 ms ± 1.1 ms	429 ms ± 0.5 ms	+0.12 %
arco-pro_production-mode + exec	3.22 s ± 82 ms	3.26 s ± 57 ms	+1.46 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec	3.22 s ± 79 ms	3.33 s ± 71 ms	+3.27 %
threejs_development-mode_10x + exec	1.64 s ± 12 ms	1.65 s ± 16 ms	+0.71 %
threejs_development-mode_10x_hmr + exec	784 ms ± 14 ms	776 ms ± 12 ms	-1.03 %
threejs_production-mode_10x + exec	5.03 s ± 52 ms	5.39 s ± 20 ms	+7.24 %

Threshold exceeded: ["threejs_production-mode_10x + exec"]

hardfist · 2024-11-01T09:26:17Z

!bench

rspack-bot · 2024-11-01T09:26:37Z

📝 Benchmark detail: Open

Name	Base (2024-11-01 4aeee85)	Current	Change
10000_big_production-mode + exec	47.5 s ± 1.45 s	43.4 s ± 856 ms	-8.58 %
10000_development-mode + exec	2.08 s ± 13 ms	1.85 s ± 13 ms	-11.19 %
10000_development-mode_hmr + exec	649 ms ± 13 ms	656 ms ± 16 ms	+0.95 %
10000_production-mode + exec	2.62 s ± 29 ms	2.41 s ± 16 ms	-7.94 %
arco-pro_development-mode + exec	1.78 s ± 79 ms	1.79 s ± 63 ms	+0.89 %
arco-pro_development-mode_hmr + exec	428 ms ± 1.1 ms	428 ms ± 1.5 ms	-0.06 %
arco-pro_production-mode + exec	3.22 s ± 82 ms	3.28 s ± 94 ms	+1.92 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec	3.22 s ± 79 ms	3.38 s ± 91 ms	+5.00 %
threejs_development-mode_10x + exec	1.64 s ± 12 ms	1.65 s ± 21 ms	+0.69 %
threejs_development-mode_10x_hmr + exec	784 ms ± 14 ms	782 ms ± 6.1 ms	-0.26 %
threejs_production-mode_10x + exec	5.03 s ± 52 ms	5.39 s ± 28 ms	+7.11 %

Threshold exceeded: ["threejs_production-mode_10x + exec"]

hardfist · 2024-11-01T10:15:44Z

!bench

rspack-bot · 2024-11-01T10:16:07Z

📝 Benchmark detail: Open

Name	Base (2024-11-01 4aeee85)	Current	Change
10000_big_production-mode + exec	47.5 s ± 1.45 s	44.6 s ± 3.65 s	-6.14 %
10000_development-mode + exec	2.08 s ± 13 ms	1.86 s ± 21 ms	-10.64 %
10000_development-mode_hmr + exec	649 ms ± 13 ms	650 ms ± 14 ms	+0.01 %
10000_production-mode + exec	2.62 s ± 29 ms	2.43 s ± 34 ms	-7.34 %
arco-pro_development-mode + exec	1.78 s ± 79 ms	1.8 s ± 69 ms	+1.08 %
arco-pro_development-mode_hmr + exec	428 ms ± 1.1 ms	429 ms ± 2 ms	+0.08 %
arco-pro_production-mode + exec	3.22 s ± 82 ms	3.28 s ± 95 ms	+2.02 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec	3.22 s ± 79 ms	3.4 s ± 94 ms	+5.40 %
threejs_development-mode_10x + exec	1.64 s ± 12 ms	1.66 s ± 19 ms	+0.89 %
threejs_development-mode_10x_hmr + exec	784 ms ± 14 ms	776 ms ± 12 ms	-1.00 %
threejs_production-mode_10x + exec	5.03 s ± 52 ms	5.38 s ± 51 ms	+6.90 %

Threshold exceeded: ["arco-pro_production-mode_generate-package-json-webpack-plugin + exec","threejs_production-mode_10x + exec"]

crates/rspack_binding_options/src/options/raw_module/mod.rs

crates/rspack_core/src/utils/task_loop.rs

crates/rspack_error/Cargo.toml

hardfist · 2024-11-01T10:40:15Z

!bench

rspack-bot · 2024-11-01T10:40:39Z

📝 Benchmark detail: Open

Name	Base (2024-11-01 4aeee85)	Current	Change
10000_big_production-mode + exec	47.5 s ± 1.45 s	46 s ± 1.06 s	-3.10 %
10000_development-mode + exec	2.08 s ± 13 ms	1.83 s ± 17 ms	-12.21 %
10000_development-mode_hmr + exec	649 ms ± 13 ms	644 ms ± 1.8 ms	-0.81 %
10000_production-mode + exec	2.62 s ± 29 ms	2.4 s ± 22 ms	-8.23 %
arco-pro_development-mode + exec	1.78 s ± 79 ms	1.75 s ± 64 ms	-1.79 %
arco-pro_development-mode_hmr + exec	428 ms ± 1.1 ms	429 ms ± 3 ms	+0.22 %
arco-pro_production-mode + exec	3.22 s ± 82 ms	3.2 s ± 85 ms	-0.49 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec	3.22 s ± 79 ms	3.26 s ± 59 ms	+1.33 %
threejs_development-mode_10x + exec	1.64 s ± 12 ms	1.64 s ± 16 ms	+0.09 %
threejs_development-mode_10x_hmr + exec	784 ms ± 14 ms	777 ms ± 11 ms	-0.82 %
threejs_production-mode_10x + exec	5.03 s ± 52 ms	5.04 s ± 35 ms	+0.25 %

github-actions bot added the team The issue/pr is created by the member of Rspack. label Oct 26, 2024

hardfist force-pushed the yj/main-thread-pool branch from a2d4250 to 9ea503e Compare October 26, 2024 14:26

hardfist force-pushed the yj/main-thread-pool branch from 5150032 to e8a33c5 Compare October 29, 2024 02:23

hardfist force-pushed the yj/main-thread-pool branch from e8a33c5 to 2830db5 Compare October 29, 2024 02:50

refactor: remove Handle::current().block_on

5f64e8c

feat(core): bump swc

cc4a693

hardfist added 2 commits November 1, 2024 17:51

chore: enable manual-tokio-runtime

176c611

chore: fix shear

153f8a5

hardfist marked this pull request as ready for review November 1, 2024 10:09

hardfist requested a review from jerrykingxyz as a code owner November 1, 2024 10:09

github-actions bot assigned hardfist Nov 1, 2024

hardfist requested review from ahabhgk and h-a-n-a November 1, 2024 10:09

hardfist commented Nov 1, 2024

View reviewed changes

crates/rspack_binding_options/src/options/raw_module/mod.rs Show resolved Hide resolved

hardfist commented Nov 1, 2024

View reviewed changes

crates/rspack_core/src/utils/task_loop.rs Show resolved Hide resolved

hardfist commented Nov 1, 2024

View reviewed changes

crates/rspack_core/src/utils/task_loop.rs Show resolved Hide resolved

hardfist commented Nov 1, 2024

View reviewed changes

crates/rspack_core/src/utils/task_loop.rs Show resolved Hide resolved

hardfist commented Nov 1, 2024

View reviewed changes

crates/rspack_error/Cargo.toml Show resolved Hide resolved

chore: revert concurrent

cd03d15

h-a-n-a approved these changes Nov 1, 2024

View reviewed changes

hardfist merged commit 7f96765 into main Nov 1, 2024

hardfist deleted the yj/main-thread-pool branch November 1, 2024 11:11

hardfist mentioned this pull request Nov 1, 2024

[Tracking]: migrate all blocking call to async call #8312

Closed

Uh oh!

Conversation

hardfist commented Oct 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

hardfist commented Oct 26, 2024

Uh oh!

netlify bot commented Oct 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rspack canceled.

Uh oh!

rspack-bot commented Oct 26, 2024

Uh oh!

hardfist commented Oct 26, 2024

Uh oh!

rspack-bot commented Oct 26, 2024

Uh oh!

hardfist commented Oct 26, 2024

Uh oh!

rspack-bot commented Oct 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hardfist commented Oct 26, 2024

Uh oh!

rspack-bot commented Oct 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hardfist commented Oct 26, 2024

Uh oh!

rspack-bot commented Oct 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hardfist commented Oct 26, 2024

Uh oh!

rspack-bot commented Oct 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hardfist commented Oct 27, 2024

Uh oh!

rspack-bot commented Oct 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hardfist commented Oct 27, 2024

Uh oh!

rspack-bot commented Oct 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hardfist commented Oct 27, 2024

Uh oh!

rspack-bot commented Oct 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hardfist commented Oct 28, 2024

Uh oh!

rspack-bot commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hardfist commented Oct 29, 2024

Uh oh!

rspack-bot commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hardfist commented Oct 29, 2024

Uh oh!

rspack-bot commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hardfist commented Oct 29, 2024

Uh oh!

rspack-bot commented Nov 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hardfist commented Nov 1, 2024

Uh oh!

rspack-bot commented Nov 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hardfist commented Nov 1, 2024

hardfist commented Oct 26, 2024 •

edited

Loading

netlify bot commented Oct 26, 2024 •

edited

Loading

rspack-bot commented Oct 26, 2024 •

edited

Loading

rspack-bot commented Oct 26, 2024 •

edited

Loading

rspack-bot commented Oct 26, 2024 •

edited

Loading

rspack-bot commented Oct 26, 2024 •

edited

Loading

rspack-bot commented Oct 27, 2024 •

edited

Loading

rspack-bot commented Oct 27, 2024 •

edited

Loading

rspack-bot commented Oct 27, 2024 •

edited

Loading

rspack-bot commented Oct 28, 2024 •

edited

Loading

rspack-bot commented Oct 29, 2024 •

edited

Loading

rspack-bot commented Oct 29, 2024 •

edited

Loading

rspack-bot commented Nov 1, 2024 •

edited

Loading

rspack-bot commented Nov 1, 2024 •

edited

Loading

rspack-bot commented Nov 1, 2024 •

edited

Loading

rspack-bot commented Nov 1, 2024 •

edited

Loading

rspack-bot commented Nov 1, 2024 •

edited

Loading

rspack-bot commented Nov 1, 2024 •

edited

Loading