Skip to content

feat: unify js module#8210

Merged
SyMind merged 33 commits intomainfrom
modules
Oct 31, 2024
Merged

feat: unify js module#8210
SyMind merged 33 commits intomainfrom
modules

Conversation

@SyMind
Copy link
Copy Markdown
Member

@SyMind SyMind commented Oct 24, 2024 •
edited
Loading

Summary

  1. Remove old JsModule and ModuleDTO.
  2. New JsModule save Module and Compilation raw pointer.
  3. New JsCompilation save Compilation raw pointer.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Oct 24, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 24, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 0b115de
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/672341a2ca0ae80008bfb53d

@web-infra-dev web-infra-dev deleted a comment from rspack-bot Oct 28, 2024
@web-infra-dev web-infra-dev deleted a comment from rspack-bot Oct 29, 2024
@SyMind
Copy link
Copy Markdown
Member Author

SyMind commented Oct 29, 2024

!bench

@rspack-bot
Copy link
Copy Markdown

rspack-bot commented Oct 29, 2024 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2024-10-29 a901d54) Current Change
10000_development-mode + exec 2.11 s ± 23 ms 2.13 s ± 40 ms +0.76 %
10000_development-mode_hmr + exec 672 ms ± 22 ms 646 ms ± 10 ms -3.82 %
10000_production-mode + exec 2.71 s ± 62 ms 2.7 s ± 32 ms -0.46 %
arco-pro_development-mode + exec 1.78 s ± 66 ms 1.79 s ± 69 ms +0.33 %
arco-pro_development-mode_hmr + exec 430 ms ± 8.4 ms 428 ms ± 1 ms -0.55 %
arco-pro_production-mode + exec 3.2 s ± 91 ms 3.23 s ± 93 ms +0.92 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.23 s ± 81 ms 3.29 s ± 157 ms +1.78 %
threejs_development-mode_10x + exec 1.61 s ± 18 ms 1.66 s ± 17 ms +2.71 %
threejs_development-mode_10x_hmr + exec 765 ms ± 11 ms 758 ms ± 2.9 ms -0.95 %
threejs_production-mode_10x + exec 5.02 s ± 35 ms 5.06 s ± 25 ms +0.87 %

@SyMind SyMind force-pushed the modules branch 2 times, most recently from 14898ba to b77be19 Compare October 31, 2024 07:54
@SyMind SyMind marked this pull request as ready for review October 31, 2024 08:36
@SyMind SyMind merged commit 6fb9afa into main Oct 31, 2024
@SyMind SyMind deleted the modules branch October 31, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees

@SyMind SyMind

Labels

release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SyMind @rspack-bot @ahabhgk