Skip to content

test: add rspack.default should not exist test#8207

Merged
SoonIter merged 1 commit intomainfrom
soon_241024/default-export-test
Oct 24, 2024
Merged

test: add rspack.default should not exist test#8207
SoonIter merged 1 commit intomainfrom
soon_241024/default-export-test

Conversation

@SoonIter
Copy link
Copy Markdown
Member

@SoonIter SoonIter commented Oct 24, 2024

Summary

enhance the test of #8169

at present, we use module.exports = rspack to overrides the tsup output to not to export the rspack.default

rspack.default.rspack is not expected by all of us

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@SoonIter SoonIter enabled auto-merge (squash) October 24, 2024 03:45
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 24, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 4da05fa
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6719c2bf0b75be00086384c3

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Oct 24, 2024
@SoonIter SoonIter changed the title test: add rspack.default should not exist test test: add rspack.default should not exist test Oct 24, 2024
@SoonIter SoonIter merged commit eb1d013 into main Oct 24, 2024
@SoonIter SoonIter deleted the soon_241024/default-export-test branch October 24, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants