Skip to content

refactor: add JSDoc to improve config.experiments types#8184

Merged
GiveMe-A-Name merged 1 commit intomainfrom
refactor/configuration-experiments
Oct 22, 2024
Merged

refactor: add JSDoc to improve config.experiments types#8184
GiveMe-A-Name merged 1 commit intomainfrom
refactor/configuration-experiments

Conversation

@GiveMe-A-Name
Copy link
Copy Markdown
Member

Summary

Zod types system is not easy to understand by user.

We tend use raw ts provider intellisense and jsDoc for user in ide.

  • Add type & JSDoc for config.experiments

See #4241 more detail.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@GiveMe-A-Name GiveMe-A-Name requested review from JSerFeng and ahabhgk and removed request for ahabhgk October 22, 2024 06:35
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 22, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit c994fd6
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/671747b9fcc0b70008550585

@GiveMe-A-Name GiveMe-A-Name merged commit bcf3ee0 into main Oct 22, 2024
@GiveMe-A-Name GiveMe-A-Name deleted the refactor/configuration-experiments branch October 22, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants