Skip to content

docs: rename shareScope to shareStrategy#8173

Merged
chenjiahan merged 1 commit intoweb-infra-dev:mainfrom
86XIng:main
Oct 21, 2024
Merged

docs: rename shareScope to shareStrategy#8173
chenjiahan merged 1 commit intoweb-infra-dev:mainfrom
86XIng:main

Conversation

@86XIng
Copy link
Copy Markdown
Contributor

@86XIng 86XIng commented Oct 21, 2024

Summary

shareScope should be rename to shareStrategy in Chinese docs.

Ref: https://rspack.dev/zh/plugins/webpack/module-federation-plugin#sharescope-1

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the release: document release: document related release(mr only) label Oct 21, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 21, 2024

Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a526b01
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6715c82ab32a760008d68d8e
😎 Deploy Preview https://deploy-preview-8173--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chenjiahan chenjiahan merged commit 5d8c0c1 into web-infra-dev:main Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: document release: document related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants