Skip to content

fix: should keep comments of esm export#8168

Merged
LingyuCoder merged 4 commits intomainfrom
fix/harmony-export-comment
Oct 18, 2024
Merged

fix: should keep comments of esm export#8168
LingyuCoder merged 4 commits intomainfrom
fix/harmony-export-comment

Conversation

@LingyuCoder
Copy link
Copy Markdown
Contributor

@LingyuCoder LingyuCoder commented Oct 18, 2024

Summary

Should keep comments like /* #__PURE__ */ of esm export

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Oct 18, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 18, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit f843ad6
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67122f9f9fcfb60008187e3a

@LingyuCoder LingyuCoder force-pushed the fix/harmony-export-comment branch from aece5c0 to fd357ce Compare October 18, 2024 09:11
@LingyuCoder LingyuCoder requested a review from hardfist October 18, 2024 09:11
@LingyuCoder LingyuCoder marked this pull request as ready for review October 18, 2024 09:11
@LingyuCoder LingyuCoder changed the title fix: should keep comment of esm export fix: should keep comments of esm export Oct 18, 2024
@LingyuCoder LingyuCoder marked this pull request as draft October 18, 2024 09:16
@LingyuCoder LingyuCoder marked this pull request as ready for review October 18, 2024 09:53
@LingyuCoder LingyuCoder enabled auto-merge (squash) October 18, 2024 10:04
@LingyuCoder LingyuCoder merged commit 539b10f into main Oct 18, 2024
@LingyuCoder LingyuCoder deleted the fix/harmony-export-comment branch October 18, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants