Skip to content

fix: perf degradation in devtool plugin#8147

Merged
SyMind merged 1 commit intomainfrom
perf-devtool-plugin
Oct 17, 2024
Merged

fix: perf degradation in devtool plugin#8147
SyMind merged 1 commit intomainfrom
perf-devtool-plugin

Conversation

@SyMind
Copy link
Copy Markdown
Member

@SyMind SyMind commented Oct 16, 2024

Summary

Fix perf degradation in #8136

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@SyMind
Copy link
Copy Markdown
Member Author

SyMind commented Oct 16, 2024

!bench

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Oct 16, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 16, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 5bc6002
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/670fbf12f372500008f03fbf

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Oct 16, 2024
@rspack-bot
Copy link
Copy Markdown

rspack-bot commented Oct 16, 2024 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2024-10-16 4ea491e) Current Change
10000_development-mode + exec 2.11 s ± 23 ms 2.11 s ± 26 ms +0.16 %
10000_development-mode_hmr + exec 662 ms ± 17 ms 670 ms ± 14 ms +1.14 %
10000_production-mode + exec 2.64 s ± 19 ms 2.68 s ± 24 ms +1.84 %
arco-pro_development-mode + exec 1.79 s ± 88 ms 1.82 s ± 44 ms +1.71 %
arco-pro_development-mode_hmr + exec 426 ms ± 1.5 ms 427 ms ± 0.83 ms +0.30 %
arco-pro_production-mode + exec 3.07 s ± 44 ms 3.19 s ± 62 ms +3.85 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.13 s ± 84 ms 3.24 s ± 43 ms +3.41 %
threejs_development-mode_10x + exec 1.61 s ± 22 ms 1.61 s ± 17 ms -0.11 %
threejs_development-mode_10x_hmr + exec 759 ms ± 9.2 ms 760 ms ± 9.9 ms +0.17 %
threejs_production-mode_10x + exec 4.9 s ± 23 ms 4.96 s ± 21 ms +1.34 %

@SyMind SyMind changed the title fix: perf degradation fix: perf degradation in devtool plugin Oct 16, 2024
@SyMind SyMind requested a review from h-a-n-a October 16, 2024 13:51
@SyMind SyMind marked this pull request as ready for review October 16, 2024 13:51
@chenjiahan
Copy link
Copy Markdown
Member

chenjiahan commented Oct 17, 2024

How was this perf degradation discovered?

@SyMind SyMind merged commit 040af59 into main Oct 17, 2024
@SyMind SyMind deleted the perf-devtool-plugin branch October 17, 2024 07:25
@SyMind
Copy link
Copy Markdown
Member Author

SyMind commented Oct 17, 2024 •
edited
Loading

@chenjiahan I updated rspack-sources yesterday, and I expected it to cause some performance degradation. However, today I noticed that the extent of the performance degradation was not as expected, so I checked yesterday's PR.

@chenjiahan
Copy link
Copy Markdown
Member

chenjiahan commented Oct 17, 2024

Get 👍

yifancong pushed a commit that referenced this pull request Oct 17, 2024
@SyMind @yifancong
fix: perf degradation in devtool plugin (#8147)
8fb89c6 
fix: perf degradation
@Narretz
Copy link
Copy Markdown

Narretz commented Oct 22, 2024

Can someone explain how the benchmark works? Because I see "current" here, and it has +% almost everywhere. Doesn't it mean the change is slower than before?

@SyMind
Copy link
Copy Markdown
Member Author

SyMind commented Oct 23, 2024

@Narretz The benchmark differs from 4ea491e.

Within this range, there is a specific performance degradation caused by rolling back a particular algorithm in rspack-sources. However, after rolling back the code, I found that the degradation was greater than expected, with a maximum degradation of 6.83%.

I reviewed other commits and discovered another unexpected degradation. This commit is intended to fix that, and then the degradation of this benchmark is as expected.

@renovate renovate bot mentioned this pull request Nov 26, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@h-a-n-a h-a-n-a h-a-n-a approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@SyMind SyMind

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SyMind @rspack-bot @chenjiahan @Narretz @h-a-n-a