fix: generate correct worker expression with trusted types#8143
Merged
LingyuCoder merged 1 commit intomainfrom Oct 18, 2024
Merged
fix: generate correct worker expression with trusted types#8143LingyuCoder merged 1 commit intomainfrom
LingyuCoder merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ahabhgk
approved these changes
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix #8134
When
output.trustedTypesis set, thenew Worker(new URL(xxx))should be compiled tonew Worker(__webpack_reuqire__.tu(new URL(xxx))), but now it is compiled tonew Worker(new URL(__webpack_require__.tu(xxx)))The
webpack-test/configCases/trusted-types/web-workercase can pass because the mock environment does not havetrustedTypes.createPolicyso that the__webpack_require__.tu(xxx)will returnxxxdirectly.Checklist