chore(workflow): merge website folder to the root pnpm workspace#8114
Merged
chenjiahan merged 3 commits intomainfrom Oct 15, 2024
Merged
chore(workflow): merge website folder to the root pnpm workspace#8114chenjiahan merged 3 commits intomainfrom
chenjiahan merged 3 commits intomainfrom
Conversation
✅ Deploy Preview for rspack canceled.
|
hardfist
approved these changes
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merge website folder to the root pnpm workspace.
Motivations:
pnpm-workspace.yamlfiles in one monorepo is not a good practice, it forces our contributors to runpnpm iin two different folders frequently.check-dependency-version-consistencyCI andRenovatebot can work correctly for thewebsitefolder.The root pnpm-lock.yaml now contains more dependencies, but the difference is acceptable, and we can further optimize the number of dependencies included in the website in the future.
Checklist