Skip to content

fix: generate code correctly for dynamically importing the same file#8100

Merged
LingyuCoder merged 3 commits intoweb-infra-dev:mainfrom
inottn:fix/context
Oct 14, 2024
Merged

fix: generate code correctly for dynamically importing the same file#8100
LingyuCoder merged 3 commits intoweb-infra-dev:mainfrom
inottn:fix/context

Conversation

@inottn
Copy link
Copy Markdown
Collaborator

@inottn inottn commented Oct 13, 2024

Summary

Port webpack/webpack#18755

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Oct 13, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 13, 2024

Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 53292fb
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/670cda1c36880d00086708c6
😎 Deploy Preview https://deploy-preview-8100--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LingyuCoder
Copy link
Copy Markdown
Contributor

Seems that the chunkName and groupOptions can also be added here

@inottn
Copy link
Copy Markdown
Collaborator Author

inottn commented Oct 14, 2024

Seems that the chunkName and groupOptions can also be added here

done~

Copy link
Copy Markdown
Contributor

@LingyuCoder LingyuCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@LingyuCoder LingyuCoder merged commit 69e3bc3 into web-infra-dev:main Oct 14, 2024
@inottn inottn deleted the fix/context branch October 14, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants