Merged
Conversation
Contributor
Author
|
!bench |
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
⏳ Triggered benchmark: Open |
c2ac5ee to
73f5ace
Compare
Contributor
Author
|
!bench |
|
📝 Benchmark detail: Open
|
73f5ace to
bfb5f76
Compare
Contributor
Author
|
!bench |
|
📝 Benchmark detail: Open
|
ahabhgk
approved these changes
Oct 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently we use
ModuleIdentifierto accessModuleandModuleGraphModule, but need to convert the dependency_id to the connection_id to access theConnection, which will cause additional performance loss.This PR will remove ConnectionId and use DependencyId to access Connection.
NOTE: There are some inactive connections in the module graph that cannot be found from the dependency ID. This is useful when you need to print debug information, but it makes the module graph more cluttered. We will use some other methods to ensure these features.
Checklist