Skip to content

chore(docs): rsdoctor add the note for CssExtractRspackPlugin#8087

Merged
yifancong merged 2 commits intomainfrom
chore/fix-rsdoctor-docs
Oct 17, 2024
Merged

chore(docs): rsdoctor add the note for CssExtractRspackPlugin#8087
yifancong merged 2 commits intomainfrom
chore/fix-rsdoctor-docs

Conversation

@yifancong
Copy link
Copy Markdown
Contributor

@yifancong yifancong commented Oct 11, 2024

Summary

[Docs] Rsdoctor add the note for CssExtractRspackPlugin

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Oct 11, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit bbd3f90
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6710d7eeb2c76d00082155e7
😎 Deploy Preview https://deploy-preview-8087--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yifancong yifancong force-pushed the chore/fix-rsdoctor-docs branch from 9668975 to ce062ee Compare October 11, 2024 04:26
Copy link
Copy Markdown
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move this note to the Rsdoctor documentation?

@yifancong
Copy link
Copy Markdown
Contributor Author

yifancong commented Oct 11, 2024

Should we move this note to the Rsdoctor documentation?

@chenjiahan
Did you mean moving "Use Rsdoctor" to Rspack's website or to Rsdoctor's website?

I'll also add it to Rsdoctor's website. If you were referring to the Rspack website, I think this note should be placed near the loader profile documentation for Rsdoctor.

@chenjiahan
Copy link
Copy Markdown
Member

chenjiahan commented Oct 11, 2024

I mean move "this note" to the Rsdoctor website.

If Rsdoctor already provides this note, I don't recommend maintaining two copies of the same content. You can just link to the Rsdoctor documentation.

Considering that the Rsbuild documentation also has a "Use Rsdoctor" section, it is unreasonable to maintain multiple copies of the same content.

@yifancong yifancong force-pushed the chore/fix-rsdoctor-docs branch 2 times, most recently from fa02da1 to da31894 Compare October 12, 2024 10:19
chenjiahan
chenjiahan previously approved these changes Oct 16, 2024
@chenjiahan chenjiahan dismissed their stale review October 16, 2024 06:31

CI broken

@chenjiahan
Copy link
Copy Markdown
Member

CI broken:

image

@yifancong yifancong force-pushed the chore/fix-rsdoctor-docs branch from fdb2ef0 to 3e4cf77 Compare October 17, 2024 09:12
chore(docs): rsdoctor add the note for CssExtractRspackPlugin

chore(docs): fix rsdoctor docs
@yifancong yifancong force-pushed the chore/fix-rsdoctor-docs branch from 3e4cf77 to 19fc1c4 Compare October 17, 2024 09:13
@yifancong
Copy link
Copy Markdown
Contributor Author

CI broken:

image

@chenjiahan this is be ok~

@yifancong yifancong enabled auto-merge (squash) October 17, 2024 09:16
@yifancong yifancong merged commit 0017a68 into main Oct 17, 2024
@yifancong yifancong deleted the chore/fix-rsdoctor-docs branch October 17, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants