Skip to content

fix: css module should not calculate id#8084

Merged
JSerFeng merged 1 commit intomainfrom
fix/css-module-id
Oct 12, 2024
Merged

fix: css module should not calculate id#8084
JSerFeng merged 1 commit intomainfrom
fix/css-module-id

Conversation

@JSerFeng
Copy link
Copy Markdown
Contributor

Summary

css-extract turns a css into 2 modules, a normal module and a css module, they have the same short_name, in webpack, css module not calculate id

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Oct 10, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 10, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit b23c029
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6709048d01ee6700088c68ea
😎 Deploy Preview https://deploy-preview-8084--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JSerFeng JSerFeng force-pushed the fix/css-module-id branch 4 times, most recently from 01834b9 to a57b28c Compare October 11, 2024 10:05
@JSerFeng JSerFeng marked this pull request as ready for review October 12, 2024 04:22
@JSerFeng JSerFeng requested a review from ahabhgk October 12, 2024 04:22
@JSerFeng JSerFeng merged commit aad975b into main Oct 12, 2024
@JSerFeng JSerFeng deleted the fix/css-module-id branch October 12, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants