Skip to content

fix: should support chunk.contentHash in PathData of compilation.getPath#8074

Merged
LingyuCoder merged 5 commits intomainfrom
fix/path-data-chunk-contenthash
Oct 10, 2024
Merged

fix: should support chunk.contentHash in PathData of compilation.getPath#8074
LingyuCoder merged 5 commits intomainfrom
fix/path-data-chunk-contenthash

Conversation

@LingyuCoder
Copy link
Copy Markdown
Contributor

@LingyuCoder LingyuCoder commented Oct 9, 2024 •
edited
Loading

Summary

Should render [contenthash] with combining chunk.contentHash and contentHashType in PathData of compilation.getPath

  • Add contentHashType to PathData
  • Use pathData.chunk.contentHash[pathData.contentHashType] instead when pathData.contentHash is None
  • Need to pass the output.hashDigestLength to render of filename template which need it to generate final contentHash strings

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Oct 9, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 9, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit cc80397
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67074defc0fba70009fdb374

@LingyuCoder LingyuCoder requested a review from SyMind October 10, 2024 04:00
@LingyuCoder LingyuCoder merged commit ab9c645 into main Oct 10, 2024
@LingyuCoder LingyuCoder deleted the fix/path-data-chunk-contenthash branch October 10, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SyMind SyMind SyMind approved these changes

Assignees

@LingyuCoder LingyuCoder

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LingyuCoder @SyMind