Skip to content

fix: avoid renaming the export name when outputting a library#8046

Merged
fi3ework merged 2 commits intoweb-infra-dev:mainfrom
inottn:fix/8045
Oct 11, 2024
Merged

fix: avoid renaming the export name when outputting a library#8046
fi3ework merged 2 commits intoweb-infra-dev:mainfrom
inottn:fix/8045

Conversation

@inottn
Copy link
Copy Markdown
Collaborator

@inottn inottn commented Oct 3, 2024

Summary

fix #8045

Checklist

  • Tests updated (or not required).`
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Oct 3, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 3, 2024

Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 286863c
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6708d157d348ff00089654c4
😎 Deploy Preview https://deploy-preview-8046--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan requested review from ahabhgk and hardfist October 3, 2024 09:32
@chenjiahan chenjiahan requested a review from fi3ework October 11, 2024 06:09
Copy link
Copy Markdown
Member

@fi3ework fi3ework left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think move the test case to tests/webpack-test/configCases/library/rspack-issue-8045 could be more accurate. Generally LGTM.

@fi3ework fi3ework enabled auto-merge (squash) October 11, 2024 07:24
@fi3ework fi3ework merged commit 0dc49c0 into web-infra-dev:main Oct 11, 2024
@inottn inottn deleted the fix/8045 branch October 11, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Default export of library is undefined in final build

2 participants