Skip to content

refactor: add JSDoc & types to improve configuration.resolve types.#8029

Merged
chenjiahan merged 1 commit intomainfrom
refactor/configuration-resolve-types
Sep 30, 2024
Merged

refactor: add JSDoc & types to improve configuration.resolve types.#8029
chenjiahan merged 1 commit intomainfrom
refactor/configuration-resolve-types

Conversation

@GiveMe-A-Name
Copy link
Copy Markdown
Member

Summary

  • Add type & JSDoc for configuration.resolve

See #4241 more detail.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 30, 2024

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link
Copy Markdown

netlify bot commented Sep 30, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 766bc0d
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66fa477d01841f00089a219e

@GiveMe-A-Name GiveMe-A-Name force-pushed the refactor/configuration-resolve-types branch from 92db092 to 766bc0d Compare September 30, 2024 06:38
Copy link
Copy Markdown
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chenjiahan chenjiahan merged commit 5c261d9 into main Sep 30, 2024
@chenjiahan chenjiahan deleted the refactor/configuration-resolve-types branch September 30, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants