Skip to content

refactor: add JSDoc to improve Rspack configuration.entry|context|mode types#8016

Merged
GiveMe-A-Name merged 1 commit intoweb-infra-dev:mainfrom
GiveMe-A-Name:refactor/configuration-entry-types
Oct 8, 2024
Merged

refactor: add JSDoc to improve Rspack configuration.entry|context|mode types#8016
GiveMe-A-Name merged 1 commit intoweb-infra-dev:mainfrom
GiveMe-A-Name:refactor/configuration-entry-types

Conversation

@GiveMe-A-Name
Copy link
Copy Markdown
Member

…context] types.

Zod types system is not easy to understand by user.

We tend use raw ts provider intellisense and jsDoc for user in ide.

  • Add type & JSDoc for config.entry
  • Add type & JSDoc for config.context
  • Add type & JSDoc for config.dependencies
  • Add type & JSDoc for config.mode

See #4241 more detail.

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Sep 29, 2024

Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit cb36dbf
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6704a3a22d7ade00084e3a9e
😎 Deploy Preview https://deploy-preview-8016--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@GiveMe-A-Name GiveMe-A-Name changed the title refactor: add JSDoc to improve Rspack configuration types refactor: add JSDoc to improve Rspack configuration types Sep 29, 2024
@GiveMe-A-Name GiveMe-A-Name changed the title refactor: add JSDoc to improve Rspack configuration types refactor: add JSDoc to improve Rspack configuration.entry|context|mode types Sep 29, 2024
@GiveMe-A-Name GiveMe-A-Name force-pushed the refactor/configuration-entry-types branch from 483d5cb to eac1ead Compare September 30, 2024 07:12
@GiveMe-A-Name GiveMe-A-Name requested review from ahabhgk and h-a-n-a and removed request for ahabhgk September 30, 2024 07:12
@GiveMe-A-Name GiveMe-A-Name force-pushed the refactor/configuration-entry-types branch from eac1ead to 10116d6 Compare September 30, 2024 07:16
@GiveMe-A-Name GiveMe-A-Name force-pushed the refactor/configuration-entry-types branch from 10116d6 to cb36dbf Compare October 8, 2024 03:14
Copy link
Copy Markdown
Contributor

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GiveMe-A-Name GiveMe-A-Name merged commit 4ab10ce into web-infra-dev:main Oct 8, 2024
@GiveMe-A-Name GiveMe-A-Name deleted the refactor/configuration-entry-types branch December 26, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants