fix: use HookMap for runtimeRequirementInTree#7987
Merged
LingyuCoder merged 4 commits intoweb-infra-dev:mainfrom Sep 26, 2024
Merged
fix: use HookMap for runtimeRequirementInTree#7987LingyuCoder merged 4 commits intoweb-infra-dev:mainfrom
HookMap for runtimeRequirementInTree#7987LingyuCoder merged 4 commits intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
Collaborator
Author
|
This PR should be merged after rstackjs/rspack-lite-tapable#5 is merged. |
This is a breaking change to Rspack 1.0.6.
e6e5ff2 to
66fc108
Compare
ahabhgk
approved these changes
Sep 26, 2024
HookMap for runtimeRequirementInTreeHookMap for runtimeRequirementInTree
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Caution
This PR is a breaking change because
compilation.hooks.runtimeRequirementInTree.tapis not avaliableChange
compilation.hooks.runtimeRequirementInTreetoHookMap. This is aligned with Webpack.Checklist