feat: support require.ensure#7972
Merged
LingyuCoder merged 18 commits intoweb-infra-dev:mainfrom Oct 21, 2024
Merged
Conversation
✅ Deploy Preview for rspack ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
89550ef to
a96f4b9
Compare
55c6e8b to
b7664de
Compare
LingyuCoder
reviewed
Oct 19, 2024
LingyuCoder
reviewed
Oct 19, 2024
LingyuCoder
reviewed
Oct 19, 2024
crates/rspack_plugin_javascript/src/dependency/commonjs/require_ensure_dependency.rs
Show resolved
Hide resolved
LingyuCoder
reviewed
Oct 19, 2024
crates/rspack_plugin_javascript/src/dependency/commonjs/require_ensure_dependency.rs
Show resolved
Hide resolved
Contributor
|
Perhaps some cases can be added to the runtime diff test to make sure that the generated runtime code is full aligned with webpack. |
b7664de to
2bb207e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #4304
Because rspack has not supported some API yet, this pr doesn't fully align
require.ensureto webpack. But I think it's enough to use.parser.in_scopewhen addingRequireEnsureItemDependencyto depBlock. This API is marked as deprecated.parser.state.current = depBlock, which bundles the modules required in the success body to the created AsyncDependencyBlock. But rspack doesn't not support nested blocks yet.Related test case: https://github.com/web-infra-dev/rspack/tree/3beef37ec09a565da86b8211e6712655f6aefa32/tests/webpack-test/configCases/parsing/issue-14720
Reated webpack issue: Inside require.ensure, using require with chained property causes dependencies to be added to wrong chunk webpack/webpack#14720
Checklist