Skip to content

refactor: import module hooks#7967

Merged
JSerFeng merged 2 commits intomainfrom
fix/import-module-hooks
Sep 25, 2024
Merged

refactor: import module hooks#7967
JSerFeng merged 2 commits intomainfrom
fix/import-module-hooks

Conversation

@JSerFeng
Copy link
Copy Markdown
Contributor

Summary

import module should use different plugin_driver compare to main compilation, so that plugins won't operate incorrect compilation

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Sep 24, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 24, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit a8d9a1b
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66f3e26ee063ce000883d841

@JSerFeng JSerFeng changed the title fix: import module hooks refactor: import module hooks Sep 24, 2024
@JSerFeng
Copy link
Copy Markdown
Contributor Author

!eco-ci

@rspack-bot
Copy link
Copy Markdown

rspack-bot commented Sep 24, 2024

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
nx ❌ failure
rspress ✅ success
rslib ✅ success
rsbuild ✅ success
examples ✅ success
devserver ✅ success

@JSerFeng JSerFeng force-pushed the fix/import-module-hooks branch from 22281a1 to 5d0cba7 Compare September 24, 2024 13:28
@JSerFeng
Copy link
Copy Markdown
Contributor Author

!eco-ci

@rspack-bot
Copy link
Copy Markdown

rspack-bot commented Sep 24, 2024

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
nx ❌ failure
rspress ✅ success
rslib ✅ success
rsbuild ✅ success
examples ✅ success
devserver ✅ success

@JSerFeng JSerFeng force-pushed the fix/import-module-hooks branch from 5d0cba7 to d81cabf Compare September 25, 2024 05:28
@JSerFeng JSerFeng force-pushed the fix/import-module-hooks branch 2 times, most recently from 2001073 to 1dfb7d4 Compare September 25, 2024 06:26
@JSerFeng JSerFeng marked this pull request as ready for review September 25, 2024 07:22
@JSerFeng JSerFeng requested a review from ahabhgk September 25, 2024 07:22
ahabhgk
ahabhgk previously approved these changes Sep 25, 2024
@JSerFeng JSerFeng merged commit cfd514a into main Sep 25, 2024
@JSerFeng JSerFeng deleted the fix/import-module-hooks branch September 25, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants