Skip to content

chore: not allow run typecheck when run node bin/rspack for other project#7964

Merged
chenjiahan merged 1 commit intomainfrom
yj/disable-tsnode-typecheck
Sep 24, 2024
Merged

chore: not allow run typecheck when run node bin/rspack for other project#7964
chenjiahan merged 1 commit intomainfrom
yj/disable-tsnode-typecheck

Conversation

@hardfist
Copy link
Copy Markdown
Contributor

@hardfist hardfist commented Sep 24, 2024

Summary

when use local build rspack bin to debug other projects, rspack will auto do typecheck which may fail

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@hardfist hardfist requested a review from chenjiahan September 24, 2024 11:11
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Sep 24, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 24, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 2d9cb56
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66f29e3c33697000085884b7

@hardfist hardfist requested a review from JSerFeng September 24, 2024 12:20
@chenjiahan chenjiahan merged commit 7688797 into main Sep 24, 2024
@chenjiahan chenjiahan deleted the yj/disable-tsnode-typecheck branch September 24, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants