feat: support dependencies in resolve hook callback#7949
Merged
Conversation
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ea7f594 to
0b15c10
Compare
0b15c10 to
c69a361
Compare
f08b9da to
7d6519c
Compare
771b014 to
c1f8f8e
Compare
65251ef to
8caa426
Compare
8caa426 to
183afd8
Compare
Contributor
|
what is the usecase for this |
Member
Author
|
@hardfist Fix todo in PR to support |
Member
Author
|
Another aspect is to prepare for supporting the |
h-a-n-a
previously approved these changes
Oct 10, 2024
h-a-n-a
approved these changes
Oct 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix todo in PR to support
moment-locales-webpack-plugin.Another aspect is to prepare for supporting the
Content CallbackofContextReplacementPlugin. In this callback, you can modifydependency.criticalto ignore the errors that would occur during the original parsing of theContextModule. For example: https://github.com/microsoft/vscode-dapr/blob/5b860c3e9ce120604067680aa67c844b8ac08704/webpack.config.ts#L95Checklist