Skip to content

feat(core): support using tokio-console#7945

Merged
hardfist merged 2 commits intomainfrom
support-tokio-console
Sep 23, 2024
Merged

feat(core): support using tokio-console#7945
hardfist merged 2 commits intomainfrom
support-tokio-console

Conversation

@hardfist
Copy link
Copy Markdown
Contributor

@hardfist hardfist commented Sep 22, 2024 •
edited
Loading

Summary

support debug scheduler problem using tokio console
we can spot which task takes long time using tokio-console

$ cargo install tokio-console
$ RSPACK_PROFILE=trace rspack dev -c rspack.config.js
$ tokio-console

image
image

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Sep 22, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 22, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 0ab0c78
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66efdde02e5fee00084c8125

@hardfist hardfist requested a review from h-a-n-a September 22, 2024 16:04
h-a-n-a
h-a-n-a reviewed Sep 23, 2024
View reviewed changes
@hardfist hardfist requested a review from h-a-n-a September 23, 2024 07:40
@hardfist hardfist merged commit cba52b5 into main Sep 23, 2024
@hardfist hardfist deleted the support-tokio-console branch September 23, 2024 07:56
@chenjiahan
Copy link
Copy Markdown
Member

chenjiahan commented Nov 21, 2024

This crate is quite big:

image

@hardfist
Copy link
Copy Markdown
Contributor Author

hardfist commented Nov 21, 2024

it's not necessary now, we can remove it

@chenjiahan
Copy link
Copy Markdown
Member

chenjiahan commented Nov 21, 2024

Nice 👍

@chenjiahan chenjiahan mentioned this pull request Dec 12, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@h-a-n-a h-a-n-a h-a-n-a approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hardfist hardfist

Labels

release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hardfist @chenjiahan @h-a-n-a