feat(parser): add new javascript parser options#7939
Merged
ahabhgk merged 7 commits intoweb-infra-dev:mainfrom Oct 9, 2024
Merged
feat(parser): add new javascript parser options#7939ahabhgk merged 7 commits intoweb-infra-dev:mainfrom
ahabhgk merged 7 commits intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rspack canceled.
|
8ed9800 to
f00b9d4
Compare
42 tasks
efa5cf5 to
0cad17d
Compare
0cad17d to
49c38fe
Compare
ahabhgk
reviewed
Oct 8, 2024
crates/rspack_plugin_javascript/src/parser_plugin/common_js_imports_parse_plugin.rs
Outdated
Show resolved
Hide resolved
crates/rspack_plugin_javascript/src/parser_plugin/common_js_imports_parse_plugin.rs
Outdated
Show resolved
Hide resolved
crates/rspack_plugin_javascript/src/parser_plugin/import_parser_plugin.rs
Outdated
Show resolved
Hide resolved
ahabhgk
previously approved these changes
Oct 9, 2024
Contributor
ahabhgk
left a comment
There was a problem hiding this comment.
I am ok with the current implementation, but we should keep it as experiment for now, or at least hide it from docs, and wait for implementing it in webpack to have a more stable implementation
Member
Author
Sure. Any why to make it as experimental now? Or just using name like |
Contributor
|
An experimental warning in jsdoc and hide these options from rspack docs looks good to me |
ahabhgk
approved these changes
Oct 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix web-infra-dev/rslib#204 and more.
We'll try to merge this back into webpack after stabilized.
Checklist