fix: infer async modules when incremental enabled#7927
Conversation
✅ Deploy Preview for rspack canceled.
|
|
!bench |
|
📝 Benchmark detail: Open
|
5d8827a to
663959b
Compare
|
Can you explain the issue before ? |
|
for example, in the first build, c has top-level-await, this will infer a and b are async modules ( but in the second build, we remove the top-level-await inside c, the correct module graph should be in this PR we will fix this first in InferAsyncModulesPlugin, we find the and when newIncremental disabled, old incremental enabled or nothing enabled at all, the affected modules is just all modules, follow the same steps, will also have a correctly updated module graph |
Why are |
Summary
fix infer async modules when incremental enabled (both incremental and newIncremental)
This could cause a little bit perf regression when cold start but correctness first and the regression is acceptable (under 5% according to the bench)shouldn't cause perf regressionChecklist